Add osg-htc Harbor project support - #316 - #317
Merged
matyasselmeci merged 9 commits intoJul 29, 2026
Conversation
We seemingly drop this on the floor, otherwise jq chokes on this input
Member
Author
|
@mwestphall I think we should add #315 to the |
There was a problem hiding this comment.
Pull request overview
This PR updates the container build workflow to support building (and subsequently pushing) images that live under either opensciencegrid/ or the new osg-htc/ top-level directory, and adjusts the build matrix so the build context is the full <org>/<image> path.
Changes:
- Expand image discovery in the workflow from
opensciencegrid/only toopensciencegrid/andosg-htc/. - Change the build matrix “name” to carry the full image directory path (e.g.,
osg-htc/<image>), and use that directly as the build/pushcontext. - Modernize matrix output handling (move away from deprecated
::set-output) and attempt to handle “no images changed” cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/build-job-matrix.py | Emits matrix entries keyed by full image directory path instead of basename. |
| .github/workflows/build-containers.yml | Detects image dirs under both opensciencegrid/ and osg-htc/, and uses full-path matrix context for build/push steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Matyas Selmeci <mselmeci@wisc.edu>
matyasselmeci
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanding on the commit in #308 . This might work out of the box -- the account appears to have osg-htc push permissions
Take 2 after some more validation on my own fork.