Smoother augment_profile#10
Open
jacekkopecky wants to merge 5 commits intoopenscad:masterfrom
Open
Conversation
shows visible distortion with insert_extra_vertices_0
this is in insert_extra_vertices_1
Author
|
Hi, do we have any maintainers here please? I know no commits happened in over 3 years, but maybe? |
|
Thanks for submitting. This looks like a reasonable approach. (note that both this and the original code are quite inefficient – there are better ways to do it) Have you verified that none of the samples degrade by taking this approach? |
Author
|
Hi, thanks; I'll do that but need a few more weeks before I get to it due to |
Author
|
Hi, yes, I can now confirm that all the other examples in this repo that use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
augment_profileinskin.scadinserts new vertices in a profile so that the result has a given number of vertices. Currently, the order of insertions is not specified, and in some cases the new vertices cause distortion.This profile (in context of
extrusion.scad) demonstrates the issue: the cylinder is visibly distorted:This image shows the distortion.

The example above is artificial, but the issue comes up when combining profiles that you naturally produce with different vertex counts.
This pull requests introduces
insert_extra_vertices_1which distributes new vertices uniformly around the length of the profile, resulting in much smaller distortions.I'll be happy to polish the code if need be.