Conversation
rebkwok
force-pushed
the
template-coverage
branch
from
8878809 to
32fd041
Compare
rebkwok
force-pushed
the
template-coverage
branch
2 times, most recently
from
4c687cf to
fca2aad
Compare
And test request view with a filegroup; this should be the default now - every file has to be in at least the default grop.
rebkwok
force-pushed
the
template-coverage
branch
from
fca2aad to
0bc8f12
Compare
evansd
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds coverage for templates, using the existing django_coverage_plugin, but with a tweak to handle slippers components.
This means we (hopefully temporarily) have our own fork of the plugin, until this PR gets in. Without it, any slippers component end tags that are on their own line - which is lots of them - get marked as uncovered.
As a result of writing the tests for the uncovered template lines, I found a breadcrumbs block in the login template that was unused, and noticed that if you go to the login page when you're already logged in, you weren't getting redirect anywhere, you just got the login page again.