Fix 2 AssertJ migration recipe issues found via large-scale validation#914
Merged
Fix 2 AssertJ migration recipe issues found via large-scale validation#914
Conversation
1. SimplifyRedundantAssertJChains: Don't drop isNotNull() before isNotEqualTo()/isNotSameAs() - These assertions pass when actual is null, so isNotNull() is not redundant - Found ~107 incorrect transformations in Spring Framework alone 2. TruthThrowableAssertions: Handle 4 additional hasMessageThat() chains - Added conversions for containsMatch, doesNotContain, startsWith, endsWith - Prevents leaving Truth-only methods that cause compilation errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed two issues discovered by running the AssertJ composite recipe against 12 real-world repositories (generating 4,139 patches):
SimplifyRedundantAssertJChains: Don't drop
isNotNull()beforeisNotEqualTo()/isNotSameAs()since these assertions pass when actual is null, making the null check not redundant. Found ~107 incorrect transformations in Spring Framework alone.TruthThrowableAssertions: Added handlers for 4 additional
hasMessageThat()chains (containsMatch,doesNotContain,startsWith,endsWith) to prevent leaving Truth-only method calls that cause compilation errors.Test Plan
isNotNull()before negated assertions