Add maven-compiler-plugin version when missing during Java migration#989
Merged
jkschneider merged 1 commit intomainfrom Feb 18, 2026
Merged
Add maven-compiler-plugin version when missing during Java migration#989jkschneider merged 1 commit intomainfrom
jkschneider merged 1 commit intomainfrom
Conversation
When maven-compiler-plugin has no <version> tag and uses <source>/<target>, the migration converts to <release> but the default plugin version (3.1) doesn't support it. Set addVersionIfMissing on UpgradePluginVersion so a compatible version is always present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maven-compiler-pluginis declared without a<version>tag and uses<source>/<target>configuration, the Java migration recipes convert to<release>but don't add a plugin version. Maven 3.x defaults to plugin version 3.1 which doesn't support<release>(introduced in 3.6), causing build failures.addVersionIfMissing: trueto theUpgradePluginVersioncalls formaven-compiler-pluginin the Java 11, 17, and 25 migration recipes.Test plan
compilerPluginVersionAddedWhenMissingtest verifyingUpgradePluginsForJava11adds a version to a versionless plugincompilerPluginVersionAddedAndReleaseSetForFullMigrationintegration test verifying the fullJava8toJava11recipe sets both<release>11</release>and a plugin version