Skip to content

Fix method patterns for dead UnsignedInts/UnsignedLongs recipes #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 3 commits into from
Jul 26, 2026
+155 −46
Merged

Fix method patterns for dead UnsignedInts/UnsignedLongs recipes #1176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d67e58
Fix method patterns for `UnsignedInts`/`UnsignedLongs` recipes
timtebeek Jul 26, 2026
1afc6f9
Drop nonexistent Guava methods from recipe descriptions
timtebeek Jul 26, 2026
4fc2823
Match unsigned methods by name rather than exact parameter types
timtebeek Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 30 additions & 34 deletions src/main/resources/META-INF/rewrite/no-guava.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ recipeList:
- org.openrewrite.java.migrate.guava.PreferIntegerCompareUnsigned
- org.openrewrite.java.migrate.guava.PreferIntegerDivideUnsigned
- org.openrewrite.java.migrate.guava.PreferIntegerParseUnsignedInt
- org.openrewrite.java.migrate.guava.PreferIntegerRemainderUnsigned
- org.openrewrite.java.migrate.guava.PreferJavaStringJoin
- org.openrewrite.java.migrate.guava.PreferLongCompareUnsigned
- org.openrewrite.java.migrate.guava.PreferLongDivideUnsigned
Expand Down Expand Up @@ -362,38 +363,34 @@ recipeList:
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.migrate.guava.PreferIntegerCompareUnsigned
displayName: Prefer `Integer#compareUnsigned`
description: >-
Prefer `java.lang.Integer#compareUnsigned` instead of using `com.google.common.primitives.UnsignedInts#compare` or
`com.google.common.primitives.UnsignedInts#compareUnsigned`.
description: Prefer `java.lang.Integer#compareUnsigned` instead of using `com.google.common.primitives.UnsignedInts#compare`.
tags:
- guava
preconditions:
- org.openrewrite.Singleton
recipeList:
- org.openrewrite.java.ChangeMethodName:
methodPattern: com.google.common.primitives.UnsignedInts compare(int, int)
methodPattern: com.google.common.primitives.UnsignedInts compare(..)
newMethodName: compareUnsigned
- org.openrewrite.java.ChangeMethodTargetToStatic:
methodPattern: com.google.common.primitives.UnsignedInts compareUnsigned(int, int)
methodPattern: com.google.common.primitives.UnsignedInts compareUnsigned(..)
fullyQualifiedTargetTypeName: java.lang.Integer

---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.migrate.guava.PreferIntegerDivideUnsigned
displayName: Prefer `Integer#divideUnsigned`
description: >-
Prefer `java.lang.Integer#divideUnsigned` instead of using `com.google.common.primitives.UnsignedInts#divide` or
`com.google.common.primitives.UnsignedInts#divideUnsigned`.
description: Prefer `java.lang.Integer#divideUnsigned` instead of using `com.google.common.primitives.UnsignedInts#divide`.
tags:
- guava
preconditions:
- org.openrewrite.Singleton
recipeList:
- org.openrewrite.java.ChangeMethodName:
methodPattern: com.google.common.primitives.UnsignedInts divide(int, int)
methodPattern: com.google.common.primitives.UnsignedInts divide(..)
newMethodName: divideUnsigned
- org.openrewrite.java.ChangeMethodTargetToStatic:
methodPattern: com.google.common.primitives.UnsignedInts divideUnsigned(int, int)
methodPattern: com.google.common.primitives.UnsignedInts divideUnsigned(..)
fullyQualifiedTargetTypeName: java.lang.Integer

---
Expand All @@ -414,86 +411,89 @@ recipeList:
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.migrate.guava.PreferIntegerRemainderUnsigned
displayName: Prefer `Integer#remainderUnsigned`
description: Prefer `java.lang.Integer#remainderUnsigned` instead of using `com.google.common.primitives.UnsignedInts#remainderUnsigned`.
description: Prefer `java.lang.Integer#remainderUnsigned` instead of using `com.google.common.primitives.UnsignedInts#remainder`.
tags:
- guava
preconditions:
- org.openrewrite.Singleton
recipeList:
- org.openrewrite.java.ChangeMethodName:
methodPattern: com.google.common.primitives.UnsignedInts remainder(..)
newMethodName: remainderUnsigned
- org.openrewrite.java.ChangeMethodTargetToStatic:
methodPattern: com.google.common.primitives.UnsignedInts remainderUnsigned(int, int)
methodPattern: com.google.common.primitives.UnsignedInts remainderUnsigned(..)
fullyQualifiedTargetTypeName: java.lang.Integer

---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.migrate.guava.PreferLongCompareUnsigned
displayName: Prefer `Long#compareUnsigned`
description: >-
Prefer `java.lang.Long#compareUnsigned` instead of using `com.google.common.primitives.UnsignedLongs#compare` or
`com.google.common.primitives.UnsignedLongs#compareUnsigned`.
description: Prefer `java.lang.Long#compareUnsigned` instead of using `com.google.common.primitives.UnsignedLongs#compare`.
tags:
- guava
preconditions:
- org.openrewrite.Singleton
recipeList:
- org.openrewrite.java.ChangeMethodName:
methodPattern: com.google.common.primitives.UnsignedLongs compare(int, int)
methodPattern: com.google.common.primitives.UnsignedLongs compare(..)
newMethodName: compareUnsigned
- org.openrewrite.java.ChangeMethodTargetToStatic:
methodPattern: com.google.common.primitives.UnsignedLongs compareUnsigned(int, int)
methodPattern: com.google.common.primitives.UnsignedLongs compareUnsigned(..)
fullyQualifiedTargetTypeName: java.lang.Long

---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.migrate.guava.PreferLongDivideUnsigned
displayName: Prefer `Long#divideUnsigned`
description: >-
Prefer `java.lang.Long#divideUnsigned` instead of using `com.google.common.primitives.UnsignedLongs#divide` or
`com.google.common.primitives.UnsignedLongs#divideUnsigned`.
description: Prefer `java.lang.Long#divideUnsigned` instead of using `com.google.common.primitives.UnsignedLongs#divide`.
tags:
- guava
preconditions:
- org.openrewrite.Singleton
recipeList:
- org.openrewrite.java.ChangeMethodName:
methodPattern: com.google.common.primitives.UnsignedLongs divide(int, int)
methodPattern: com.google.common.primitives.UnsignedLongs divide(..)
newMethodName: divideUnsigned
- org.openrewrite.java.ChangeMethodTargetToStatic:
methodPattern: com.google.common.primitives.UnsignedLongs divideUnsigned(int, int)
methodPattern: com.google.common.primitives.UnsignedLongs divideUnsigned(..)
fullyQualifiedTargetTypeName: java.lang.Long

---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.migrate.guava.PreferLongParseUnsignedLong
displayName: Prefer `Long#parseUnsignedInt`
description: Prefer `java.lang.Long#parseUnsignedInt` instead of using `com.google.common.primitives.UnsignedLongs#parseUnsignedInt`.
displayName: Prefer `Long#parseUnsignedLong`
description: Prefer `java.lang.Long#parseUnsignedLong` instead of using `com.google.common.primitives.UnsignedLongs#parseUnsignedLong`.
tags:
- guava
preconditions:
- org.openrewrite.Singleton
recipeList:
- org.openrewrite.java.ChangeMethodTargetToStatic:
methodPattern: com.google.common.primitives.UnsignedInts parseUnsignedLong(String, ..)
methodPattern: com.google.common.primitives.UnsignedLongs parseUnsignedLong(String, ..)
fullyQualifiedTargetTypeName: java.lang.Long

---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.migrate.guava.PreferLongRemainderUnsigned
displayName: Prefer `Long#remainderUnsigned`
description: Prefer `java.lang.Long#remainderUnsigned` instead of using `com.google.common.primitives.UnsignedLongs#remainderUnsigned`.
description: Prefer `java.lang.Long#remainderUnsigned` instead of using `com.google.common.primitives.UnsignedLongs#remainder`.
tags:
- guava
preconditions:
- org.openrewrite.Singleton
recipeList:
- org.openrewrite.java.ChangeMethodName:
methodPattern: com.google.common.primitives.UnsignedLongs remainder(..)
newMethodName: remainderUnsigned
- org.openrewrite.java.ChangeMethodTargetToStatic:
methodPattern: com.google.common.primitives.UnsignedLongs remainderUnsigned(int, int)
methodPattern: com.google.common.primitives.UnsignedLongs remainderUnsigned(..)
fullyQualifiedTargetTypeName: java.lang.Long

---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.migrate.guava.PreferMathAddExact
displayName: Prefer `Math#addExact`
description: Prefer `java.lang.Math#addExact` instead of using `com.google.common.math.IntMath#checkedAdd` or `com.google.common.math.IntMath#addExact`.
description: Prefer `java.lang.Math#addExact` instead of using `com.google.common.math.IntMath#checkedAdd`.
tags:
- guava
preconditions:
Expand All @@ -510,9 +510,7 @@ recipeList:
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.migrate.guava.PreferMathSubtractExact
displayName: Prefer `Math#subtractExact`
description: >-
Prefer `java.lang.Math#subtractExact` instead of using `com.google.common.primitives.IntMath#checkedSubtract`
or `com.google.common.primitives.IntMath#subtractExact`.
description: Prefer `java.lang.Math#subtractExact` instead of using `com.google.common.math.IntMath#checkedSubtract`.
tags:
- guava
preconditions:
Expand All @@ -529,9 +527,7 @@ recipeList:
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.migrate.guava.PreferMathMultiplyExact
displayName: Prefer `Math#multiplyExact`
description: >-
Prefer `java.lang.Math#multiplyExact` instead of using `com.google.common.primitives.IntMath#checkedMultiply`
or `com.google.common.primitives.IntMath#multiplyExact`.
description: Prefer `java.lang.Math#multiplyExact` instead of using `com.google.common.math.IntMath#checkedMultiply`.
tags:
- guava
preconditions:
Expand Down
Loading
Loading