bugfix: add assert for ngx_stream_lua_get_req in ngx_stream_lua_sema_timeout_handler#407
Open
petrvaganoff wants to merge 1 commit into
Open
bugfix: add assert for ngx_stream_lua_get_req in ngx_stream_lua_sema_timeout_handler#407petrvaganoff wants to merge 1 commit into
petrvaganoff wants to merge 1 commit into
Conversation
…imeout_handler DEREF_OF_NULL.RET.STAT Return value of a function 'ngx_stream_lua_get_req' is dereferenced at ngx_stream_lua_semaphore.c:537 without checking for NULL, but it is usually checked for this function (35/41). Found by Linux Verification Center with Svace. Signed-off-by: Petr Vaganov <petrvaganoff@gmail.com>
Author
|
Why I see an error of title RP? UPD: |
petrvaganoff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEREF_OF_NULL.RET.STAT Return value of a function 'ngx_stream_lua_get_req' is dereferenced at ngx_stream_lua_semaphore.c:537 without checking for NULL, but it is usually checked for this function (35/41).
Add assert for consistent of code.
Found by Linux Verification Center with Svace.