feature: add optional arguments to constructor: socket, boundary/header#56
Open
un-def wants to merge 1 commit intoopenresty:masterfrom
Open
feature: add optional arguments to constructor: socket, boundary/header#56un-def wants to merge 1 commit intoopenresty:masterfrom
un-def wants to merge 1 commit intoopenresty:masterfrom
Conversation
Author
|
The CI build failed with the following error: Not totally sure but it seems unrelated to the changes introduced in the PR. All tests are passed locally with openresty/1.15.8.3 on Ubuntu 20.04 x64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds two new arguments to the
newmethod:content-typeheader value (in the latter case the boundary value will be parsed from the header value)For example, the cosocket object can be already instantiated for some reason. In this case the library cannot be used now because the second
ngx.req.socket()call inside the library returns an error (request body already exists). If one could pass the cosocket object the thenewmethod, the problem would be solved.Another interesting feature of use an externally created socket object is that it doesn't have to be a real cosocket object. It can be any object with compatible interface. There is an example of how to process form-data with chunked transfer encoding: https://github.com/un-def/lua-buffet/tree/master/examples/resty-chunked-formdata It uses a socket-like object from my library instead of the real cosocket object.
The changes are backward–compatible. When the argument is not provided (or
nil), the library still gets the value using correspondingngx.*API call. When both arguments are provided, the library doesn't usengx.*API at all.