Skip to content

bugfix: prevent NULL dereference in SSL cache by ensuring old_cycle i… #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhuizhuhaomeng merged 2 commits into from
Mar 17, 2026
+13 −0
Merged

bugfix: prevent NULL dereference in SSL cache by ensuring old_cycle i… #2485

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e952e13
bugfix: prevent NULL dereference in SSL cache by ensuring old_cycle i…
oowl Mar 16, 2026
3ba3da1
fix
oowl Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/ngx_http_lua_initworkerby.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,19 @@ ngx_http_lua_init_worker(ngx_cycle_t *cycle)

ngx_memcpy(fake_cycle, cycle, sizeof(ngx_cycle_t));

/*
* nginx clears cycle->old_cycle after ngx_init_cycle() completes.
* Since nginx 1.29.2, ngx_ssl_cache_fetch() accesses old_cycle->conf_ctx
* without a NULL guard, so we must ensure old_cycle is non-NULL.
* This avoids a NULL dereference when merge_loc_conf triggers
* ngx_ssl_trusted_certificate.
* Pointing to the current cycle is safe: the SSL cache is shared via
* conf_ctx, so cert lookups still find previously loaded entries.
*/
if (fake_cycle->old_cycle == NULL) {
fake_cycle->old_cycle = cycle;
}

ngx_queue_init(&fake_cycle->reusable_connections_queue);

if (ngx_array_init(&fake_cycle->listening, cycle->pool,
Expand Down
Loading