Add dynamic lists overflow verification to react skill#2290
Merged
Conversation
Require overflow/scroll verification whenever components render variable-length lists. This prevents UI bugs where long lists push buttons and footers off-screen. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “Dynamic Lists & Overflow” section to the React agent skill to require explicit overflow/scroll verification when rendering variable-length lists, aiming to prevent UI controls from being pushed off-screen (OPS-804).
Changes:
- Introduces a new checklist for dynamic list overflow constraints, including data-volume and viewport-size verification.
- Renumbers subsequent sections to accommodate the new guidance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace FixedHeightScrollArea (internal-only) with the existing ScrollArea component. Remove qa-agent reference that doesn't exist in the OSS repo. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
ravikiranvm
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a Dynamic Lists & Overflow section (Section 7) to the react agent skill, requiring overflow/scroll verification whenever components render variable-length lists.
Motivation
During campaign wizard work, mock connection data was added without catching that the list container had no scroll constraint — long lists pushed buttons off-screen. The fix required manually creating a
FixedHeightScrollAreacomponent and wrapping all wizard steps.This skill update ensures the agent proactively checks overflow behavior when working with dynamic lists.
What's added
The new section requires:
FixedHeightScrollArea)overflow-clipparents, buttons pushed off-screenPart of OPS-4263