Skip to content

Add support for assuming AWS role via Azure VM managed identity#2261

Open
MarceloRGonc wants to merge 24 commits intomainfrom
mg/assume-role-azure
Open

Add support for assuming AWS role via Azure VM managed identity#2261
MarceloRGonc wants to merge 24 commits intomainfrom
mg/assume-role-azure

Conversation

@MarceloRGonc
Copy link
Copy Markdown
Contributor

@MarceloRGonc MarceloRGonc commented May 4, 2026

Part of OPS-4254.

Comment thread packages/openops/src/lib/aws/get-client.ts Fixed
@MarceloRGonc MarceloRGonc changed the title Test azure Add support for assuming AWS role via Azure VM managed identity May 5, 2026
@MarceloRGonc MarceloRGonc marked this pull request as ready for review May 5, 2026 14:16
Copilot AI review requested due to automatic review settings May 5, 2026 14:16
@linear
Copy link
Copy Markdown

linear Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an Azure-managed-identity path to the shared AWS authentication helpers so OpenOps can obtain AWS credentials from an Azure VM identity and use them for implicit-role and role-assumption flows.

Changes:

  • Added new shared system properties for enabling Azure managed identity and configuring the AWS federation role ARN.
  • Introduced Azure-to-AWS federation helpers and wired them into AWS client creation and STS role assumption.
  • Updated AWS auth and test coverage to reflect the new implicit-role behavior and federation flow.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
packages/server/shared/src/lib/system/system-prop.ts Adds shared system props for Azure-managed-identity AWS federation.
packages/openops/test/aws/get-client.test.ts Extends client-construction tests for Azure-managed-identity credential loading.
packages/openops/test/aws/azure-aws-federation.test.ts Adds unit tests for Azure OIDC token exchange and AWS role federation helpers.
packages/openops/test/aws/auth.test.ts Updates AWS auth validation expectations and adds helper-function tests.
packages/openops/src/lib/aws/sts-common.ts Adds Azure-managed-identity branching to STS role assumption.
packages/openops/src/lib/aws/get-client.ts Adds Azure-managed-identity credential-provider support for AWS SDK clients.
packages/openops/src/lib/aws/azure-aws-federation.ts Implements Azure IMDS token retrieval and AWS STS federation helpers.
packages/openops/src/lib/aws/auth.ts Changes validation flow for implicit-role auth when static credentials are absent.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/openops/src/lib/aws/get-client.ts Outdated
Comment thread packages/openops/src/lib/aws/auth.ts Outdated
Comment thread packages/openops/src/lib/aws/get-client.ts
Comment thread packages/openops/test/aws/get-client.test.ts
Comment thread packages/openops/src/lib/aws/sts-common.ts
MarceloRGonc and others added 3 commits May 5, 2026 15:26
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/openops/src/lib/aws/auth.ts Outdated
Comment thread packages/openops/src/lib/aws/get-client.ts
Comment thread packages/openops/src/lib/aws/azure-aws-federation.ts
Comment thread packages/openops/src/lib/aws/azure-aws-federation.ts
Comment thread packages/openops/test/aws/get-client.test.ts Outdated
Comment thread packages/openops/src/lib/aws/azure-aws-federation.ts
Comment thread packages/openops/src/lib/aws/azure-aws-federation.ts
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/openops/src/lib/aws/auth.ts Outdated
Comment thread packages/openops/src/lib/aws/auth.ts Outdated
Comment thread packages/openops/src/lib/aws/azure-aws-federation.ts
Comment thread packages/openops/src/lib/aws/azure-aws-federation.ts
Comment thread packages/openops/test/aws/auth.test.ts
Comment thread packages/openops/test/aws/auth.test.ts
Comment thread packages/openops/src/lib/aws/get-client.ts Outdated
MarceloRGonc and others added 4 commits May 5, 2026 16:35
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/openops/src/lib/aws/auth.ts Outdated
Comment thread packages/openops/src/lib/aws/azure-aws-federation.ts
Comment thread packages/openops/src/lib/aws/get-client.ts
Comment thread packages/openops/src/lib/aws/sts-common.ts
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/openops/src/lib/aws/auth.ts
Comment thread packages/openops/src/lib/aws/get-client.ts
Comment thread packages/openops/src/lib/aws/azure-aws-federation.ts
Comment thread packages/openops/src/lib/aws/azure-aws-federation.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants