Deduplicate AWS accounts by account ID in benchmark wizard#2121
Open
Deduplicate AWS accounts by account ID in benchmark wizard#2121
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes OPS-3839 by ensuring AWS accounts shown in the benchmark wizard are deduplicated by AWS account ID when resolving getConnectionAccounts.
Changes:
- Deduplicate AWS connection roles by parsed
accountIdwhen building benchmark wizard options. - Add a unit test to verify duplicate account IDs only produce a single wizard option.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/server/api/src/app/benchmark/providers/aws/aws-option-resolver.ts | Switches from a simple map over roles to a Map keyed by accountId to deduplicate returned account options. |
| packages/server/api/test/unit/benchmark/providers/aws/aws-option-resolver.test.ts | Adds a unit test asserting duplicate roles for the same AWS account ID result in a single returned option. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
MarceloRGonc
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-3839.