Add flowId to update-run request #1879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds flowId to the UpdateRunProgressRequest type and threads it through the flow execution codebase to support tracking flow identity during run updates.
Changes:
- Added
flowIdas a required field toUpdateRunProgressRequestschema - Updated flow execution functions to pass
flowIdparameter through the call chain - Modified engine progress service to include
flowIdin update requests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/shared/src/lib/engine/requests.ts | Added required flowId field to UpdateRunProgressRequest type definition |
| packages/server/worker/src/lib/executors/flow-job-executor.ts | Threaded flowId through setFirstRunningState and updateRunWithError functions, moved variable declarations after flow retrieval |
| packages/engine/src/lib/services/progress.service.ts | Added flowId from engine constants to the update run request payload |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bigfluffycookie
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of OPS-3195.
Additional notes: