Skip to content

Sync AWS PRs and add coding guidelines#25

Merged
conico974 merged 14 commits intomainfrom
conico/port-skills
Mar 29, 2026
Merged

Sync AWS PRs and add coding guidelines#25
conico974 merged 14 commits intomainfrom
conico/port-skills

Conversation

@conico974
Copy link
Copy Markdown
Contributor

This update ports several PRs from the OpenNextJS AWS repository and introduces SKILL.md for porting guidelines and AGENTS.md for coding standards. The changes enhance functionality and maintainability across the codebase.

Copilot AI review requested due to automatic review settings March 21, 2026 09:43
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 21, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@25
npm i https://pkg.pr.new/@opennextjs/aws@25

commit: fa26619

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports functionality and build/test improvements from the OpenNextJS AWS repository into this monorepo, and adds contributor guidance docs for porting PRs and coding standards.

Changes:

  • Preserve query parameters during i18n root-locale redirects (with trailingSlash support).
  • Extend incremental cache support for Next 15+ app pages (segmentData + postponed) and add related typings/tests.
  • Improve build tooling: robust Next config discovery, Next server patch to avoid pulling sharp, and safer traced-file copying (writable perms + platform-binary filtering).

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/open-next/src/core/routing/i18n/index.ts Updates locale redirect URL construction to preserve query params and handle trailingSlash.
packages/tests-unit/tests/core/routing/i18n.test.ts Adds coverage for locale redirects preserving query params (incl. trailingSlash).
packages/open-next/src/adapters/cache.ts Writes APP_PAGE cache entries including segmentData/postponed for Next 15+.
packages/open-next/src/types/cache.ts Adds segmentData?: Map<string, Buffer> to APP_PAGE cache type.
packages/tests-unit/tests/adapters/cache.test.ts Adds tests for APP_PAGE segmentData/postponed round-tripping.
packages/open-next/src/build/helper.ts Adds findNextConfig helper to locate Next config and detect TS.
packages/tests-unit/tests/build/helper.test.ts Adds unit tests for findNextConfig.
packages/open-next/src/build/patch/patches/patchOriginalNextConfig.ts Uses findNextConfig for importing/compiling Next config.
packages/open-next/src/build/patch/patches/patchNextServer.ts Adds AST patch rule to no-op handleNextImageRequest to avoid sharp.
packages/tests-unit/tests/build/patch/patches/patchNextServer.test.ts Adds snapshot coverage for the new Next server patch rule.
packages/open-next/src/build/copyTracedFiles.ts Ensures copied files are writable; filters non-Linux platform binaries; exports helper predicate.
packages/tests-unit/tests/build/copyTracedFiles.test.ts Adds tests for non-Linux platform package detection.
packages/open-next/package.json Updates @ast-grep/napi and AWS SDK dependencies.
packages/cloudflare/package.json Updates @ast-grep/napi version.
AGENTS.md Adds repository coding standards and command guidance for agents.
.claude/skills/port-pr/SKILL.md Adds a documented workflow for porting PRs (skill definition).
.changeset/stale-schools-beam.md Adds changeset entry for findNextConfig change.
.changeset/port-pr-1098.md Adds changeset entry for the ported PR.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .changeset/stale-schools-beam.md Outdated
Comment thread packages/open-next/src/core/routing/i18n/index.ts
Comment thread packages/open-next/src/build/copyTracedFiles.ts
Comment thread packages/open-next/src/build/patch/patches/patchNextServer.ts Outdated
Comment thread packages/tests-unit/tests/build/helper.test.ts Outdated
Comment thread AGENTS.md Outdated
Copy link
Copy Markdown
Collaborator

@james-elicx james-elicx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agent/skill files look good. worth applying the inline suggestions copilot gave though (the quotes comment).

had a quick skim through the ported prs but not dived in deep since it's a lift and a shift.

@conico974 conico974 merged commit 3dbd9ef into main Mar 29, 2026
8 checks passed
@conico974 conico974 deleted the conico/port-skills branch March 29, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants