Open
Conversation
jrobble
commented
Mar 27, 2020
Member
Author
jrobble
left a comment
There was a problem hiding this comment.
Currently there is an issue where the components are not able to read the stress test data from the bind mount volume. To address this:
- Update
docker-compose.stress.tests.ymlto add the volume to each of the component services. Look atdocker-compose.integration.test.ymlfor reference. - Add a
docker-compose.custom-components.ymlfile in the custom components repo that adds the volume to each of the component services. Update theJenkinsfileto make use of this.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @brosenberg42)
jrobble
commented
Mar 27, 2020
Member
Author
jrobble
left a comment
There was a problem hiding this comment.
Correction: Add a docker-compose.stress.test.yml file in the custom components repo ...
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @brosenberg42)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is