Skip to content

Db engine cache refactor #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 3 commits into from
May 13, 2026
+21 −18

Make sure that dispose is called on all engines

5d68b7b
Select commit
Loading
Failed to load commit list.
Merged

Db engine cache refactor #328

Make sure that dispose is called on all engines
5d68b7b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 13, 2026 in 1s

94.46% (-0.03%) compared to 1d44c05

View this Pull Request on Codecov

94.46% (-0.03%) compared to 1d44c05

Details

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.46%. Comparing base (1d44c05) to head (5d68b7b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/database/setup.py 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   94.48%   94.46%   -0.03%     
==========================================
  Files          68       68              
  Lines        3157     3159       +2     
  Branches      229      227       -2     
==========================================
+ Hits         2983     2984       +1     
- Misses        111      113       +2     
+ Partials       63       62       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov