Skip to content

[FIX] Remove tests that were copied to a different file#296

Merged
PGijsbers merged 1 commit intomainfrom
remove-moved-tests
Mar 27, 2026
Merged

[FIX] Remove tests that were copied to a different file#296
PGijsbers merged 1 commit intomainfrom
remove-moved-tests

Conversation

@PGijsbers
Copy link
Copy Markdown
Contributor

I accidentally only copied over some tests, instead of moving them in #295. This fixes that.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7dcdc408-b7bc-4eb7-84d4-92bbd789f1d6

📥 Commits

Reviewing files that changed from the base of the PR and between 99da4a0 and 93c39ce.

📒 Files selected for processing (1)
  • tests/routers/openml/study_get_test.py
💤 Files with no reviewable changes (1)
  • tests/routers/openml/study_get_test.py

Walkthrough

This pull request removes test code from the study endpoint test file. Specifically, it eliminates imports for testing utilities (pytest, SQLAlchemy components, and various model classes), test cases for creating task-based studies and attaching tasks to studies with different scenarios, and a helper function that modified database state and called the attach endpoint. The file retains tests for retrieving task studies by ID and alias. No public API declarations were altered, and 135 lines were removed.

Possibly related PRs

  • Separate out test files to one file per endpoint #295: Adds a new test file tests/routers/openml/study_attach_test.py containing the same attach-to-study tests and helper code that were removed from the study_get_test.py file in this PR, indicating tests were reorganized into a dedicated module.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: removing duplicated tests that were copied instead of moved in a previous PR.
Description check ✅ Passed The description is directly related to the changeset, explaining that tests were accidentally copied instead of moved in PR #295 and this PR removes the duplicates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-moved-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.20%. Comparing base (99da4a0) to head (93c39ce).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #296   +/-   ##
=======================================
  Coverage   54.20%   54.20%           
=======================================
  Files          38       38           
  Lines        1581     1581           
  Branches      137      137           
=======================================
  Hits          857      857           
  Misses        722      722           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PGijsbers PGijsbers merged commit a8354de into main Mar 27, 2026
9 checks passed
@PGijsbers PGijsbers deleted the remove-moved-tests branch March 27, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant