Fix collision track feature for photon transport#3946
Open
pshriwise wants to merge 17 commits into
Open
Conversation
…tron interactions
06d6e02 to
0f7f7d5
Compare
…hreading test to check only the size of the resulting collision file.
Contributor
Author
|
I came across a few other items in the course of this PR:
|
paulromano
approved these changes
May 30, 2026
Contributor
paulromano
left a comment
There was a problem hiding this comment.
Thanks @pshriwise! A few notes about updates I made:
- Simplified how the PDG number is determined for a nuclide
- Use 0 as the "empty" value instead of -1. By the PDG code specification, -1 would actually mean "anti-down quark". 0 on the other hand does not have anything assigned
- Bumped collision track file version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3945
An alternative here would be to filter out electron collision events entirely, but the documentation and file format seem to indicate that these events for electrons and positrons will be present.
Checklist