Force parallel h5py installation with setuptools<81#3782
Open
paulromano wants to merge 1 commit intoopenmc-dev:developfrom
Open
Force parallel h5py installation with setuptools<81#3782paulromano wants to merge 1 commit intoopenmc-dev:developfrom
paulromano wants to merge 1 commit intoopenmc-dev:developfrom
Conversation
Member
|
would this also work at the top of the pyproject.toml |
Contributor
Author
|
No, the failure is coming from a line in our CI script before OpenMC is installed itself. I have an idea how to fix it and will try later today or tomorrow when I have a chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR pins setuptools<81 when building parallel h5py from source in CI to avoid compatibility issues with mpi4py 3.1.4, which is pulled in as a dependency and fails to build with setuptools 81+ because it removed a
dry-runparameter that mpi4py used.Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)