Modifications to C++ plots for interactive raytrace plots#3776
Open
pshriwise wants to merge 4 commits intoopenmc-dev:developfrom
Open
Modifications to C++ plots for interactive raytrace plots#3776pshriwise wants to merge 4 commits intoopenmc-dev:developfrom
pshriwise wants to merge 4 commits intoopenmc-dev:developfrom
Conversation
…rride for some concrete method implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes some modifications to the plot classes to make them more usable purely from the C++ API. The primary focus here is the addition of a default constructor to the
SolidRayTracePlotclass. Accessors have been added to this class and others so that the attributes can be modified from C++ as well.Lastly, a refactor of the
PlottableInterfacewas performed so thatcreate_imagecan be called on any plot class (with the exception of voxel plots) to produceImageDatadirectly, which may be useful for exterior applications.In the case of the
SolidRayTracePlotthis allowsImageDatagenerated by the class to be accessed by a linked application. The combination of this capability and the newupdate_view()method to recalculate attributes derived from the camera parameters allows the class to act as an image buffer generation kernel for interactive visualization of raytraced plots. The miniapp below is a prototype. After a subsequent PR adding connections through the CAPI my aim is to enable this capability in the plotter utility.openmc-render-ex.webm
These changes shouldn't have any effect on current plotting capabilities, performance, or behavior as it exists now in OpenMC.
Checklist
I have followed the style guidelines for Python source files (if applicable)