Store atomic mass in ParticleType.#3765
Open
GuySten wants to merge 10 commits intoopenmc-dev:developfrom
Open
Conversation
paulromano
requested changes
Feb 4, 2026
Contributor
paulromano
left a comment
There was a problem hiding this comment.
Thanks @GuySten -- I think this will come in very handy. However, it would be nice to get this PR updated so that it doesn't change test results (see my comment below)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Atomic mass is a property of particle type so this PR makes atomic mass a property of the new ParticleType.
This makes the atomic mass of a particle more accessible.
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)