Skip to content

Do not ignore dagmc errors #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GuySten wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Do not ignore dagmc errors #3764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16ca073
make dagmc errors loud
GuySten Feb 3, 2026
0065f2f
fix typo
GuySten Feb 3, 2026
33b5b7a
simplify code
GuySten Feb 3, 2026
ebc9422
improve error message
GuySten Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions include/openmc/dagmc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,13 @@ class DAGUniverse : public Universe {

int32_t next_cell(int32_t surf, int32_t curr_cell, int32_t univ);

inline void dagmc_check_error(
moab::ErrorCode err_code, std::string msg = "dagmc error")
{
if (err_code != moab::MB_SUCCESS)
fatal_error(msg);
}

} // namespace openmc

#endif // OPENMC_DAGMC_ENABLED
Expand Down
61 changes: 27 additions & 34 deletions src/dagmc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,13 @@ void DAGUniverse::init_dagmc()
if (!file_exists(filename_)) {
fatal_error("Geometry DAGMC file '" + filename_ + "' does not exist!");
}
moab::ErrorCode rval = dagmc_instance_->load_file(filename_.c_str());
MB_CHK_ERR_CONT(rval);
auto rval = dagmc_instance_->load_file(filename_.c_str());
dagmc_check_error(
rval, "Failed to load geometry DAGMC file '" + filename_ + "'.");

// initialize acceleration data structures
rval = dagmc_instance_->init_OBBTree();
MB_CHK_ERR_CONT(rval);
dagmc_check_error(rval);
}

void DAGUniverse::init_metadata()
Expand All @@ -171,15 +172,13 @@ void DAGUniverse::init_metadata()
std::vector<std::string> keywords {"temp"};
std::map<std::string, std::string> dum;
std::string delimiters = ":/";
moab::ErrorCode rval;
rval = dagmc_instance_->parse_properties(keywords, dum, delimiters.c_str());
MB_CHK_ERR_CONT(rval);
auto rval =
dagmc_instance_->parse_properties(keywords, dum, delimiters.c_str());
dagmc_check_error(rval);
}

void DAGUniverse::init_geometry()
{
moab::ErrorCode rval;

// determine the next cell id
int32_t next_cell_id = 0;
for (const auto& c : model::cells) {
Expand Down Expand Up @@ -255,8 +254,8 @@ void DAGUniverse::init_geometry()
// assign cell temperature
const auto& mat = model::materials[model::material_map.at(c->material_[0])];
if (dagmc_instance_->has_prop(vol_handle, "temp")) {
rval = dagmc_instance_->prop_value(vol_handle, "temp", temp_value);
MB_CHK_ERR_CONT(rval);
auto rval = dagmc_instance_->prop_value(vol_handle, "temp", temp_value);
dagmc_check_error(rval);
double temp = std::stod(temp_value);
c->sqrtkT_.push_back(std::sqrt(K_BOLTZMANN * temp));
} else if (mat->temperature() > 0.0) {
Expand Down Expand Up @@ -323,9 +322,9 @@ void DAGUniverse::init_geometry()

// graveyard check
moab::Range parent_vols;
rval = dagmc_instance_->moab_instance()->get_parent_meshsets(
auto rval = dagmc_instance_->moab_instance()->get_parent_meshsets(
surf_handle, parent_vols);
MB_CHK_ERR_CONT(rval);
dagmc_check_error(rval);

// if this surface belongs to the graveyard
if (graveyard && parent_vols.find(graveyard) != parent_vols.end()) {
Expand Down Expand Up @@ -417,9 +416,8 @@ std::string DAGUniverse::dagmc_ids_for_dim(int dim) const
int32_t DAGUniverse::implicit_complement_idx() const
{
moab::EntityHandle ic;
moab::ErrorCode rval =
dagmc_instance_->geom_tool()->get_implicit_complement(ic);
MB_CHK_SET_ERR_CONT(rval, "Failed to get implicit complement");
auto rval = dagmc_instance_->geom_tool()->get_implicit_complement(ic);
dagmc_check_error(rval, "Failed to get implicit complement");
// off-by-one: DAGMC indices start at one
return cell_idx_offset_ + dagmc_instance_->index_by_handle(ic) - 1;
}
Expand Down Expand Up @@ -692,8 +690,9 @@ std::pair<double, int32_t> DAGCell::distance(
// create the ray
double pnt[3] = {r.x, r.y, r.z};
double dir[3] = {u.x, u.y, u.z};
MB_CHK_ERR_CONT(
dagmc_ptr_->ray_fire(vol, pnt, dir, hit_surf, dist, &p->history()));
auto rval =
dagmc_ptr_->ray_fire(vol, pnt, dir, hit_surf, dist, &p->history());
dagmc_check_error(rval);
if (hit_surf != 0) {
surf_idx =
dag_univ->surf_idx_offset_ + dagmc_ptr_->index_by_handle(hit_surf);
Expand Down Expand Up @@ -725,14 +724,13 @@ std::pair<double, int32_t> DAGCell::distance(

bool DAGCell::contains(Position r, Direction u, int32_t on_surface) const
{
moab::ErrorCode rval;
moab::EntityHandle vol = dagmc_ptr_->entity_by_index(3, dag_index_);

int result = 0;
double pnt[3] = {r.x, r.y, r.z};
double dir[3] = {u.x, u.y, u.z};
rval = dagmc_ptr_->point_in_volume(vol, pnt, result, dir);
MB_CHK_ERR_CONT(rval);
auto rval = dagmc_ptr_->point_in_volume(vol, pnt, result, dir);
dagmc_check_error(rval);
return result;
}

Expand All @@ -748,11 +746,10 @@ void DAGCell::to_hdf5_inner(hid_t group_id) const

BoundingBox DAGCell::bounding_box() const
{
moab::ErrorCode rval;
moab::EntityHandle vol = dagmc_ptr_->entity_by_index(3, dag_index_);
double min[3], max[3];
rval = dagmc_ptr_->getobb(vol, min, max);
MB_CHK_ERR_CONT(rval);
auto rval = dagmc_ptr_->getobb(vol, min, max);
dagmc_check_error(rval);
return {{min[0], min[1], min[2]}, {max[0], max[1], max[2]}};
}

Expand All @@ -776,27 +773,25 @@ double DAGSurface::evaluate(Position r) const

double DAGSurface::distance(Position r, Direction u, bool coincident) const
{
moab::ErrorCode rval;
moab::EntityHandle surf = dagmc_ptr_->entity_by_index(2, dag_index_);
moab::EntityHandle hit_surf;
double dist;
double pnt[3] = {r.x, r.y, r.z};
double dir[3] = {u.x, u.y, u.z};
rval = dagmc_ptr_->ray_fire(surf, pnt, dir, hit_surf, dist, NULL, 0, 0);
MB_CHK_ERR_CONT(rval);
auto rval = dagmc_ptr_->ray_fire(surf, pnt, dir, hit_surf, dist, NULL, 0, 0);
dagmc_check_error(rval);
if (dist < 0.0)
dist = INFTY;
return dist;
}

Direction DAGSurface::normal(Position r) const
{
moab::ErrorCode rval;
moab::EntityHandle surf = dagmc_ptr_->entity_by_index(2, dag_index_);
double pnt[3] = {r.x, r.y, r.z};
double dir[3];
rval = dagmc_ptr_->get_angle(surf, pnt, dir);
MB_CHK_ERR_CONT(rval);
auto rval = dagmc_ptr_->get_angle(surf, pnt, dir);
dagmc_check_error(rval);
return dir;
}

Expand All @@ -805,9 +800,8 @@ Direction DAGSurface::reflect(Position r, Direction u, GeometryState* p) const
assert(p);
double pnt[3] = {r.x, r.y, r.z};
double dir[3];
moab::ErrorCode rval =
dagmc_ptr_->get_angle(mesh_handle(), pnt, dir, &p->history());
MB_CHK_ERR_CONT(rval);
auto rval = dagmc_ptr_->get_angle(mesh_handle(), pnt, dir, &p->history());
dagmc_check_error(rval);
return u.reflect(dir);
}

Expand Down Expand Up @@ -849,8 +843,7 @@ int32_t next_cell(int32_t surf, int32_t curr_cell, int32_t univ)
moab::EntityHandle curr_vol = cellp->mesh_handle();

moab::EntityHandle new_vol;
moab::ErrorCode rval =
cellp->dagmc_ptr()->next_vol(surf_handle, curr_vol, new_vol);
auto rval = cellp->dagmc_ptr()->next_vol(surf_handle, curr_vol, new_vol);
if (rval != moab::MB_SUCCESS)
return -1;

Expand Down
Loading