Conversation
|
The tests does not pass because of #3743. |
|
This PR is ready for review. |
|
Thanks for the PR @GuySten! I'm wondering what your thoughts are on providing the Given that the score requires a tally have a Let me know what you think! |
|
If I remember correctly there is a case when there are only CellFrom and Cell filters without surface filters. I think if there is interest we can add in a subsequent PR attributes to the Surface objects themselves that will override the defaults in the setting object. |
Ah, yes, right you are. Part of the motivation for my comment was that we avoid additional global settings, but in light of the |
|
Haven't forgotten about this. Will give it another look tomorrow |
|
@pshriwise, are you reviewing this PR? |
Description
This PR enable openmc to calculate surface flux tallies.
Fixes #2.
Theory
https://www.tandfonline.com/doi/pdf/10.13182/NSE09-72
Checklist