Enable fission heating tallies in the random ray solver#3714
Enable fission heating tallies in the random ray solver#3714jtramm merged 9 commits intoopenmc-dev:developfrom
Conversation
11d068c to
0a077db
Compare
|
It seems as if the test failures are caused by |
|
@nuclearkevin I have two PRs (#3715 and #3716), one or both of which should resolve the gcovr issue. Please wait on one of those to be merged; at that point, retriggering the CI here should pass since it always uses a merge commit with develop (i.e., you don't need to update your branch). |
|
I saw that in 52fea6f you decided generating kappa-fission should be optional. EDIT: |
jtramm
left a comment
There was a problem hiding this comment.
Looks good to me -- thanks for submitting this!
Only minor comment is on making the kappa_fission on always rather than adding another option for it. I know the default is on but I'm comfortable with just forcing this tally rather than adding more arguments/options to the interface. Let me know if there's another angle to this though that you can see @nuclearkevin!
|
Once cell density support is merged, I'll update the kappa-fission tally here to include it. |
4f903fb to
82e7cf1
Compare
|
Added the multiplication by the cell density to this PR. Should be good for another round of review once the tests pass. |
|
@jtramm I believe this is ready for another round of review when you have the time :) |
jtramm
left a comment
There was a problem hiding this comment.
Looks good @nuclearkevin - thanks for making the changes!
9965437 to
973c6fe
Compare
Description
This PR adds tally support for fission heating (
kappa-fission) in the random ray solver. This includes additions to the automagic multi-group cross section setup to generate heating cross sections. A new test has been added to hit the changes (random_ray_auto_convert_kappa_fission).Checklist