Open
Conversation
`shutil.rmtree()` was called with a list instead of a single path, crashing any conversion flow with `del_compressed_file=True`. The `isinstance` check also misclassified strings as iterables. Fixes openmc-data-storage#20 --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.6 <noreply@anthropic.com>
Allows the package to be imported in environments without native OpenMC (e.g., CI lint/test jobs). Also hardens the `setuptools_scm` fallback. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.6 <noreply@anthropic.com>
Shared utility changes could break any conversion or download script but previously didn't trigger those CI steps. Also fixes stale path for `convert_fendl.py` and adds `convert_tendl_rand.py` to the watched file list. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.6 <noreply@anthropic.com>
Member
|
Thanks for the PR CI has an error but i think it is unrelated to this PR Which I have a fix for over here paulromano/endf-python#40 Let us see if that can be merged and come back to this soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20