Skip to content

Fix jeff CI issue#26

Open
mokagio wants to merge 3 commits intoopenmc-data-storage:mainfrom
mokagio:fix-jeff-ci
Open

Fix jeff CI issue#26
mokagio wants to merge 3 commits intoopenmc-data-storage:mainfrom
mokagio:fix-jeff-ci

Conversation

@mokagio
Copy link
Copy Markdown

@mokagio mokagio commented Apr 10, 2026

Fixes #20

  • Fix extract() crash: shutil.rmtree() was called with a list instead of a single path, and isinstance misclassified strings as iterables
  • Make openmc import optional so the package can be imported in CI environments without native OpenMC
  • Trigger CI jobs on utils.py changes and fix stale workflow paths

mokagio and others added 3 commits April 10, 2026 20:34
`shutil.rmtree()` was called with a list instead of a single path,
crashing any conversion flow with `del_compressed_file=True`.
The `isinstance` check also misclassified strings as iterables.

Fixes openmc-data-storage#20

---

Generated with the help of Claude Code, https://claude.ai/code

Co-Authored-By: Claude Code Opus 4.6 <noreply@anthropic.com>
Allows the package to be imported in environments without native
OpenMC (e.g., CI lint/test jobs).
Also hardens the `setuptools_scm` fallback.

---

Generated with the help of Claude Code, https://claude.ai/code

Co-Authored-By: Claude Code Opus 4.6 <noreply@anthropic.com>
Shared utility changes could break any conversion or download
script but previously didn't trigger those CI steps.
Also fixes stale path for `convert_fendl.py` and adds
`convert_tendl_rand.py` to the watched file list.

---

Generated with the help of Claude Code, https://claude.ai/code

Co-Authored-By: Claude Code Opus 4.6 <noreply@anthropic.com>
@shimwell
Copy link
Copy Markdown
Member

Thanks for the PR

CI has an error but i think it is unrelated to this PR

[4](https://github.com/openmc-data-storage/openmc_data/actions/runs/24239400688/job/70781851809?pr=26#step:6:855)
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.12.13/x64/lib/python3.12/site-packages/openmc/data/endf.py", line 82, in __init__
    if fh.tell() == 0:
       ^^^^^^^

Which I have a fix for over here paulromano/endf-python#40

Let us see if that can be merged and come back to this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci is failing on jeff processing

2 participants