Rebased and added automation for zOS Open Tools#195
Open
Apurv428 wants to merge 2 commits intoopenmainframeproject:masterfrom
Open
Rebased and added automation for zOS Open Tools#195Apurv428 wants to merge 2 commits intoopenmainframeproject:masterfrom
Apurv428 wants to merge 2 commits intoopenmainframeproject:masterfrom
Conversation
Signed-off-by: aashish-khatri <aashishkhatri809@gmail.com>
Signed-off-by: Apurv Sonawane <apurvsonawane28@gmail.com>
pleia2
requested changes
May 17, 2024
| file_path = os.path.join(directory, 'ZOSOpenTools.json') | ||
|
|
||
| with open(file_path, 'w') as file: | ||
| json.dump(zOS_list, file, indent=2) |
Contributor
There was a problem hiding this comment.
My suggestion regarding the logic above is to look at how the other functions save the files.
Specifically, there's output so the user knows the file has saved:
print(f"Saved!\nfilename: {q}")
So you'll want to review the code a bit to make sure something like that works, and some of this could be simplified a bit based on other examples in the script.
Contributor
|
@Apurv428 You'll also want to add this new file to src/config/supported_distros.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #110 which was addressed in the #124.
I have addressed the changes which were requested on the PR