8476: Websocket server is tied to JfrEditor

[aptmac]

This PR addresses JMC-8476, in which the current websocket server implemention ties the server to a JfrEditor page.

At the moment, the Websocket server that is used to send selection data is created from within a JfrEditor page. So every time you open a new recording file, the JfrEditor code tries to start a new websocket server. This is a problem because there is only one field in the JMC settings to set the port number, and it is global to the application. So if I open recording-1, and then use the preferences menu to start the websocket server on port 8029, if I then open up recording-2 it will also try to open a websocket server on port 8029, and fail. As a result, sending data from recording-1 will work, but recording-2 will not (this can be seen in my "before" gif below).

I have extracted the websocket code out into it's own package and made it such that there is one server for the JMC application. So now if you toggle between recordings you can still send data to whatever application you want over websocket.

Before:
(exception thrown when trying to send events from the second recording)

After:
(selecting events from multiple recordings now works)

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JMC-8476: Websocket server is tied to JfrEditor (Enhancement - P4)

Reviewers

• Marcus Hirt (@thegreystone - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/698/head:pull/698
$ git checkout pull/698

Update a local copy of the PR:
$ git checkout pull/698
$ git pull https://git.openjdk.org/jmc.git pull/698/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 698

View PR using the GUI difftool:
$ git pr show -t 698

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/698.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8476: Websocket server is tied to JfrEditor

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• a7a5ff7: 8528: UI tests fail after platform upgrade
• 8b1fbae: 8527: Add AGENTS.md file
• 643f981: 8512: Fixing various minor typos and nits
• ... and 3 more: https://git.openjdk.org/jmc/compare/5778a3e0502237db43cb0aebd3fdf4062faa86f8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (7090ee73)

[thegreystone]

Very nice! :)

[aptmac]

/integrate

[openjdk]

Going to push as commit f9ba5ef.
Since your change was applied there have been 7 commits pushed to the master branch:

• 020f06d: 8475: Writing events with fields not explicitly set can corrupt the recording
• a7a5ff7: 8528: UI tests fail after platform upgrade
• 8b1fbae: 8527: Add AGENTS.md file
• ... and 4 more: https://git.openjdk.org/jmc/compare/5778a3e0502237db43cb0aebd3fdf4062faa86f8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aptmac Pushed as commit f9ba5ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.