6832: Should allow plotting line charts for all quantities#688
6832: Should allow plotting line charts for all quantities#688aymane-harmaz wants to merge 4 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into |
|
@aymane-harmaz This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
This one effectively doubles the memory usage. For solving this and the sorting, perhaps a specialized merge sort iterator could be used instead? |
| public T peek() { | ||
| if (!this.hasPeeked) { | ||
| this.hasPeeked = true; | ||
| this.peekedElement = this.sourceIterator.next(); |
There was a problem hiding this comment.
Should there be a hasNext() check here?
There was a problem hiding this comment.
Yes, thanks for pointing that out, I have added the check in both peek() and next()
|
@aymane-harmaz Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
@aymane-harmaz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/keepalive |
|
@aymane-harmaz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
/integrate |
|
Going to push as commit 8d51efa.
Your commit was automatically rebased without conflicts. |
|
@aymane-harmaz Pushed as commit 8d51efa. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
2 participants
This PR makes sure line charts cover all the events across multiple IItemIterables, and makes it possible for linear quantities to be represented as line charts on custom pages.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/688/head:pull/688$ git checkout pull/688Update a local copy of the PR:
$ git checkout pull/688$ git pull https://git.openjdk.org/jmc.git pull/688/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 688View PR using the GUI difftool:
$ git pr show -t 688Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/688.diff
Using Webrev
Link to Webrev Comment