8370489: Some compiler tests miss the @key randomness

[rm-gh-8]

Backporting JDK-8370489: Some compiler tests miss the @key randomness.

This PR adds the missing @key randomness jtreg tag to compiler tests that use randomization via getRandomInstance() to properly categorize them for test execution filtering.

This PR is not clean because the following tests are currently not present in JDK 25

test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java
test/hotspot/jtreg/compiler/loopopts/superword/TestAliasing.java
test/hotspot/jtreg/compiler/vectorapi/VectorMaskCastIdentityTest.java

These tests were not included because it would involve backporting a fairly large commit dependency graph which includes behavioral changes (JDK-8361582, JDK-8324751 and JDK-8356760)

For parity with Oracle JDK.

It is part of a series of dependent PRs for JDK 25, related to the following list of ordered issues:

8358772: Template-Framework Library: Primitive Types
8358600: Template-Framework Library: Template for TestFramework test class
8359412: Template-Framework Library: Operations and Expressions
8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries
8370489: Some compiler tests miss the @key randomness

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST="test/hotspot/jtreg/compiler"

Results attached:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8370489 needs maintainer approval

Issue

• JDK-8370489: Some compiler tests miss the @key randomness (Bug - P5 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/389/head:pull/389
$ git checkout pull/389

Update a local copy of the PR:
$ git checkout pull/389
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/389/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 389

View PR using the GUI difftool:
$ git pr show -t 389

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/389.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into pr/388 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370489: Some compiler tests miss the @key randomness

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 14d3f56: 8377944: LowMemoryTest2.java#id1 intermittent fails OOME: Metaspace
• b51af16: 8379202: Support linktime-gc on Linux with clang
• d09e1cc: 8376684: Compile OpenJDK in headless mode without required X11 libraries
• ... and 5 more: https://git.openjdk.org/jdk25u-dev/compare/40506bd177c01335c624039650d093e85f7628b0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (b7ef2a34)
• 01: Full - Incremental (cb65699f)
• 00: Full (cb65699f)

[rm-gh-8]

Review will be requested after merging from head once the prerequisite is pushed. The merge from head will require a re-review.

[GoeLin]

Hi @rm-gh-8
I remove the fix-request tag in the meantime. Thanks for doing the prereqs.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8370489-V25-V2
git fetch https://git.openjdk.org/jdk25u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[rm-gh-8]

/approval request for backport of JDK-8370489: Some compiler tests miss the @key randomness.

This is a test fix.

This PR is not clean because the following tests are currently not present in JDK 25

test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java
test/hotspot/jtreg/compiler/loopopts/superword/TestAliasing.java
test/hotspot/jtreg/compiler/vectorapi/VectorMaskCastIdentityTest.java

These tests were not included because it would involve backporting a fairly large commit dependency graph which includes behavioral changes (JDK-8361582, JDK-8324751 and JDK-8356760)

For parity with Oracle JDK.

It is part of a series of dependent PRs for JDK 25, related to the following list of ordered issues:

8358772: Template-Framework Library: Primitive Types
8358600: Template-Framework Library: Template for TestFramework test class
8359412: Template-Framework Library: Operations and Expressions
8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries
8370489: Some compiler tests miss the @key randomness

[openjdk]

@rm-gh-8
8370489: The approval request has been updated successfully.

[rm-gh-8]

Please note that the review was approved but the bot didn't seem to pick it up.

[GoeLin]

Hi @rm-gh-8 thanks for doing the prereq changes!

[rm-gh-8]

/integrate

[openjdk]

@rm-gh-8
Your change (at version b7ef2a3) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 4975b2d.
Since your change was applied there have been 10 commits pushed to the master branch:

• 9353e89: 8321687: Test vmTestbase/nsk/jvmti/scenarios/contention/TC03/tc03t002/TestDescription.java failed: JVMTI_ERROR_THREAD_NOT_ALIVE
• b164bb0: 8373913: Refactor serialization tests to use JUnit
• 14d3f56: 8377944: LowMemoryTest2.java#id1 intermittent fails OOME: Metaspace
• ... and 7 more: https://git.openjdk.org/jdk25u-dev/compare/40506bd177c01335c624039650d093e85f7628b0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @rm-gh-8 Pushed as commit 4975b2d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.