8359412: Template-Framework Library: Operations and Expressions#386
8359412: Template-Framework Library: Operations and Expressions#386rm-gh-8 wants to merge 4 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8359412-V25
git fetch https://git.openjdk.org/jdk25u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
|
|
/approval request for backport of JDK-8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries. This is a test fix. For parity with Oracle JDK. It is part of a series of dependent PRs for JDK 25, related to the following list of ordered issues: 8358772: Template-Framework Library: Primitive Types |
|
/integrate |
|
/sponsor |
|
Going to push as commit bb350a4.
Your commit was automatically rebased without conflicts. |
|
@phohensee @rm-gh-8 Pushed as commit bb350a4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting JDK-8359412: Template-Framework Library: Operations and Expressions.
This PR extends the compiler test template framework library with Expression and Operations classes that model composable Java expressions over primitive types, enabling fuzzing of IGVN optimizations (and future vectorization) by generating random nested expressions with constrained inputs and verified outputs including TypeInt/TypeLong range and KnownBits checking.
For parity with Oracle JDK.
It is part of a series of dependent PRs for JDK 25, related to the following list of ordered issues:
8358772: Template-Framework Library: Primitive Types
8358600: Template-Framework Library: Template for TestFramework test class
8359412: Template-Framework Library: Operations and Expressions
8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries
8370489: Some compiler tests miss the @key randomness
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/hotspot/jtreg/testlibrary_tests/template_framework
make test TEST=test/hotspot/jtreg/compiler
Results attached:
windows-x64-specific-test.log
windows-x64-specific-2-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/386/head:pull/386$ git checkout pull/386Update a local copy of the PR:
$ git checkout pull/386$ git pull https://git.openjdk.org/jdk25u-dev.git pull/386/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 386View PR using the GUI difftool:
$ git pr show -t 386Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/386.diff
Using Webrev
Link to Webrev Comment