Skip to content

8359412: Template-Framework Library: Operations and Expressions#386

Closed
rm-gh-8 wants to merge 4 commits intoopenjdk:masterfrom
rm-gh-8:JDK-8359412-V25
Closed

8359412: Template-Framework Library: Operations and Expressions#386
rm-gh-8 wants to merge 4 commits intoopenjdk:masterfrom
rm-gh-8:JDK-8359412-V25

Conversation

@rm-gh-8
Copy link
Copy Markdown
Contributor

@rm-gh-8 rm-gh-8 commented Mar 13, 2026

Backporting JDK-8359412: Template-Framework Library: Operations and Expressions.

This PR extends the compiler test template framework library with Expression and Operations classes that model composable Java expressions over primitive types, enabling fuzzing of IGVN optimizations (and future vectorization) by generating random nested expressions with constrained inputs and verified outputs including TypeInt/TypeLong range and KnownBits checking.

For parity with Oracle JDK.

It is part of a series of dependent PRs for JDK 25, related to the following list of ordered issues:

8358772: Template-Framework Library: Primitive Types
8358600: Template-Framework Library: Template for TestFramework test class
8359412: Template-Framework Library: Operations and Expressions
8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries
8370489: Some compiler tests miss the @key randomness

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/hotspot/jtreg/testlibrary_tests/template_framework
make test TEST=test/hotspot/jtreg/compiler

Results attached:

windows-x64-specific-test.log
windows-x64-specific-2-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8359412 needs maintainer approval

Issue

  • JDK-8359412: Template-Framework Library: Operations and Expressions (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/386/head:pull/386
$ git checkout pull/386

Update a local copy of the PR:
$ git checkout pull/386
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/386/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 386

View PR using the GUI difftool:
$ git pr show -t 386

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/386.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Mar 13, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into pr/384 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 13, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359412: Template-Framework Library: Operations and Expressions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot changed the title Backport 0496806102bb621bdd82613d5796651d9655ea1c 8359412: Template-Framework Library: Operations and Expressions Mar 13, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 13, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 13, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review March 13, 2026 16:32
@openjdk openjdk Bot added the rfr Pull request is ready for review label Mar 13, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Mar 13, 2026

Webrevs

@openjdk-notifier
Copy link
Copy Markdown

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8359412-V25
git fetch https://git.openjdk.org/jdk25u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk Bot removed the clean Identical backport; no merge resolution required label Mar 18, 2026
@openjdk openjdk Bot added the clean Identical backport; no merge resolution required label Mar 18, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 18, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Mar 18, 2026

/approval request for backport of JDK-8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries.

This is a test fix.

For parity with Oracle JDK.

It is part of a series of dependent PRs for JDK 25, related to the following list of ordered issues:

8358772: Template-Framework Library: Primitive Types
8358600: Template-Framework Library: Template for TestFramework test class
8359412: Template-Framework Library: Operations and Expressions
8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries
8370489: Some compiler tests miss the @key randomness

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 18, 2026

@rm-gh-8
8359412: The approval request has been created successfully.

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 18, 2026
@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Mar 23, 2026

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Mar 23, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 23, 2026

@rm-gh-8
Your change (at version 1a10412) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Copy Markdown
Member

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 23, 2026

Going to push as commit bb350a4.
Since your change was applied there have been 7 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Mar 23, 2026
@openjdk openjdk Bot closed this Mar 23, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 23, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 23, 2026

@phohensee @rm-gh-8 Pushed as commit bb350a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants