8339526: C2: store incorrectly removed for clone() transformed to series of loads/stores

[shipilev]

Fixes another C2 corner case.

Additional testing:

• macos-aarch64-server-fastdebug, new test fails without the fix, passes with it
• linux-aarch64-server-fastdebug, all

---

Progress

• JDK-8339526 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339526: C2: store incorrectly removed for clone() transformed to series of loads/stores (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/377/head:pull/377
$ git checkout pull/377

Update a local copy of the PR:
$ git checkout pull/377
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 377

View PR using the GUI difftool:
$ git pr show -t 377

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/377.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339526: C2: store incorrectly removed for clone() transformed to series of loads/stores

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 0c80640: 8347167: Reduce allocation in com.sun.net.httpserver.Headers::normalize
• c7f3f8f: 8319540: GC: Make TestSelectDefaultGC use createTestJavaProcessBuilder
• b1ceddd: 8368001: java/text/Format/NumberFormat/NumberRoundTrip.java timed out
• ... and 22 more: https://git.openjdk.org/jdk25u-dev/compare/08a14fd8b53b8cda92933339ba539fb5ff54fd12...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (b06c40c2)

[shipilev]

/approval request Fixes a C2 bug, regression in JDK 21, seen in the wild. Applies cleanly. New regression test fails without the fix, passes with it. All other testing passes as well. No bugtail since several months in mainline. Usual risk for C2 changes, but the fix also looks straightforward.

[openjdk]

@shipilev
8339526: The approval request has been created successfully.

[shipilev]

Push approval granted.

/integrate

[openjdk]

Going to push as commit 68e3ee1.
Since your change was applied there have been 25 commits pushed to the master branch:

• 0c80640: 8347167: Reduce allocation in com.sun.net.httpserver.Headers::normalize
• c7f3f8f: 8319540: GC: Make TestSelectDefaultGC use createTestJavaProcessBuilder
• b1ceddd: 8368001: java/text/Format/NumberFormat/NumberRoundTrip.java timed out
• ... and 22 more: https://git.openjdk.org/jdk25u-dev/compare/08a14fd8b53b8cda92933339ba539fb5ff54fd12...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 68e3ee1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.