Skip to content

8068310: [TEST_BUG] Test javax/swing/JColorChooser/Test4234761.java fails with GTKL&F#370

Closed
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8068310-V25
Closed

8068310: [TEST_BUG] Test javax/swing/JColorChooser/Test4234761.java fails with GTKL&F#370
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8068310-V25

Conversation

@rm-gh-8
Copy link
Copy Markdown
Contributor

@rm-gh-8 rm-gh-8 commented Mar 11, 2026

Backporting JDK-8068310: [TEST_BUG] Test javax/swing/JColorChooser/Test4234761.java fails with GTKL&F.

This PR fixes a bug where Test4234761.java throws a ClassCastException (JPanel cannot be cast to JTabbedPane
) when run under the GTK Look and Feel. The GTK L&F uses a different internal component structure for JColorChooser and it doesn't use a JTabbedPane for the color panel tabs, so the test's assumption of casting a child component to JTabbedPane fails. The fix skips the test entirely under GTK L&F using jtreg.SkippedException, since the test's tab-switching logic is structurally incompatible with GTK's implementation.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/javax/swing/JColorChooser/Test4234761.java

Results attached:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8068310 needs maintainer approval

Issue

  • JDK-8068310: [TEST_BUG] Test javax/swing/JColorChooser/Test4234761.java fails with GTKL&F (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/370/head:pull/370
$ git checkout pull/370

Update a local copy of the PR:
$ git checkout pull/370
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/370/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 370

View PR using the GUI difftool:
$ git pr show -t 370

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/370.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Mar 11, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 11, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8068310: [TEST_BUG] Test javax/swing/JColorChooser/Test4234761.java fails with GTKL&F

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot changed the title Backport 31beb7d3b34c3516c326c9d29a267f6becb38805 8068310: [TEST_BUG] Test javax/swing/JColorChooser/Test4234761.java fails with GTKL&F Mar 11, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 11, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 11, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review March 11, 2026 19:55
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 11, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Mar 11, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Mar 11, 2026

Webrevs

@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Mar 12, 2026

/approval request for backport of JDK-8068310: [TEST_BUG] Test javax/swing/JColorChooser/Test4234761.java fails with GTKL&F.

This is a test fix.

For parity with Oracle JDK.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 12, 2026

@rm-gh-8
8068310: The approval request has been created successfully.

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 12, 2026
@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Mar 16, 2026

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Mar 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 16, 2026

@rm-gh-8
Your change (at version 66b4b93) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Copy Markdown
Member

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 16, 2026

Going to push as commit fdeadda.
Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Mar 16, 2026
@openjdk openjdk Bot closed this Mar 16, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 16, 2026

@shipilev @rm-gh-8 Pushed as commit fdeadda.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants