8068310: [TEST_BUG] Test javax/swing/JColorChooser/Test4234761.java fails with GTKL&F#370
8068310: [TEST_BUG] Test javax/swing/JColorChooser/Test4234761.java fails with GTKL&F#370rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8068310: [TEST_BUG] Test javax/swing/JColorChooser/Test4234761.java fails with GTKL&F. This is a test fix. For parity with Oracle JDK. |
|
/integrate |
|
/sponsor |
|
Going to push as commit fdeadda.
Your commit was automatically rebased without conflicts. |
Backporting JDK-8068310: [TEST_BUG] Test javax/swing/JColorChooser/Test4234761.java fails with GTKL&F.
This PR fixes a bug where Test4234761.java throws a ClassCastException (JPanel cannot be cast to JTabbedPane
) when run under the GTK Look and Feel. The GTK L&F uses a different internal component structure for JColorChooser and it doesn't use a JTabbedPane for the color panel tabs, so the test's assumption of casting a child component to JTabbedPane fails. The fix skips the test entirely under GTK L&F using jtreg.SkippedException, since the test's tab-switching logic is structurally incompatible with GTK's implementation.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/javax/swing/JColorChooser/Test4234761.java
Results attached:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/370/head:pull/370$ git checkout pull/370Update a local copy of the PR:
$ git checkout pull/370$ git pull https://git.openjdk.org/jdk25u-dev.git pull/370/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 370View PR using the GUI difftool:
$ git pr show -t 370Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/370.diff
Using Webrev
Link to Webrev Comment