Skip to content

8383825: Incorrect handling of Hawaii_Aleutian metazone#31046

Open
naotoj wants to merge 1 commit intoopenjdk:masterfrom
naotoj:JDK-8383825-Incorrect-Hawaii_Aleutian-metazone
Open

8383825: Incorrect handling of Hawaii_Aleutian metazone#31046
naotoj wants to merge 1 commit intoopenjdk:masterfrom
naotoj:JDK-8383825-Incorrect-Hawaii_Aleutian-metazone

Conversation

@naotoj
Copy link
Copy Markdown
Member

@naotoj naotoj commented May 5, 2026

This fixes a regression found while backporting the fix for JDK-8382020.

The previous fix records metazone names only when processing the default (001) time zone for the metazone. However, it did not handle the case where that default time zone also has its own zone-specific names.

This does not show up in mainline for Hawaii_Aleutian metazone, because the metazone's default time zone is America/Adak, which maps back to the Hawaii_Aleutian metazone. In JDK 25, however, the default time zone for Hawaii_Aleutian is Pacific/Honolulu, which has its own zone-specific names so that Hawaii can use short names such as HST/HDT instead of HAST/HADT.

As a result, when the JDK-8382020 fix is backported to JDK 25, the Hawaii_Aleutian metazone names are not generated during the build. This change processes metazone names before zone-specific names, so the default-zone metazone entry is still recorded even when the default zone has its own names.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8383825: Incorrect handling of Hawaii_Aleutian metazone (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31046/head:pull/31046
$ git checkout pull/31046

Update a local copy of the PR:
$ git checkout pull/31046
$ git pull https://git.openjdk.org/jdk.git pull/31046/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31046

View PR using the GUI difftool:
$ git pr show -t 31046

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31046.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 5, 2026

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 5, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels May 5, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 5, 2026

@naotoj The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 5, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 5, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant