8383825: Incorrect handling of Hawaii_Aleutian metazone#31046
Open
naotoj wants to merge 1 commit intoopenjdk:masterfrom
Open
8383825: Incorrect handling of Hawaii_Aleutian metazone#31046naotoj wants to merge 1 commit intoopenjdk:masterfrom
naotoj wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression found while backporting the fix for JDK-8382020.
The previous fix records metazone names only when processing the default (001) time zone for the metazone. However, it did not handle the case where that default time zone also has its own zone-specific names.
This does not show up in mainline for
Hawaii_Aleutianmetazone, because the metazone's default time zone isAmerica/Adak, which maps back to theHawaii_Aleutianmetazone. In JDK 25, however, the default time zone forHawaii_AleutianisPacific/Honolulu, which has its own zone-specific names so that Hawaii can use short names such asHST/HDTinstead ofHAST/HADT.As a result, when the JDK-8382020 fix is backported to JDK 25, the
Hawaii_Aleutianmetazone names are not generated during the build. This change processes metazone names before zone-specific names, so the default-zone metazone entry is still recorded even when the default zone has its own names.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31046/head:pull/31046$ git checkout pull/31046Update a local copy of the PR:
$ git checkout pull/31046$ git pull https://git.openjdk.org/jdk.git pull/31046/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31046View PR using the GUI difftool:
$ git pr show -t 31046Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31046.diff
Using Webrev
Link to Webrev Comment