Skip to content

8382273: Update nsk/jvmti/unit tests to use ThreadWrapper#31043

Draft
shivshah-oracle wants to merge 1 commit intoopenjdk:masterfrom
shivshah-oracle:JDK-8382273
Draft

8382273: Update nsk/jvmti/unit tests to use ThreadWrapper#31043
shivshah-oracle wants to merge 1 commit intoopenjdk:masterfrom
shivshah-oracle:JDK-8382273

Conversation

@shivshah-oracle
Copy link
Copy Markdown
Contributor

@shivshah-oracle shivshah-oracle commented May 5, 2026

Converted 14 nsk/jvmti/unit tests from extends Thread to extends ThreadWrapper so they can run with both platform and virtual threads

For tests with native methods expecting a Thread (GetStackTrace, GetFrameCount, CheckMonitorInfo, RegisterCompletedThread), changed the native signatures to take Thread and pass .getThread() at the call sites

earlyretbase is left unconverted its native code does GetObjectClass on the thread to find activeMethod(), so it needs the wrapper class for method lookup but the real Thread for JVMTI operations. That one probably needs a separate approach.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8382273: Update nsk/jvmti/unit tests to use ThreadWrapper (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31043/head:pull/31043
$ git checkout pull/31043

Update a local copy of the PR:
$ git checkout pull/31043
$ git pull https://git.openjdk.org/jdk.git pull/31043/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31043

View PR using the GUI difftool:
$ git pr show -t 31043

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31043.diff

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 5, 2026

👋 Welcome back shivshah-oracle! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 5, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the serviceability serviceability-dev@openjdk.org label May 5, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 5, 2026

@shivshah-oracle The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant