Skip to content

8383864: G1: Separate worker-local refinement data from shared concurrent refinement stats#31040

Open
albertnetymk wants to merge 1 commit intoopenjdk:masterfrom
albertnetymk:g1-stats-atomic
Open

8383864: G1: Separate worker-local refinement data from shared concurrent refinement stats#31040
albertnetymk wants to merge 1 commit intoopenjdk:masterfrom
albertnetymk:g1-stats-atomic

Conversation

@albertnetymk
Copy link
Copy Markdown
Member

@albertnetymk albertnetymk commented May 5, 2026

This change adds a plain G1RefineData for worker-local refinement counters and has G1ConcurrentRefineStats atomically aggregate that data at the end of each worker task. Sweep and yield timing remain accounted directly in the shared stats.

Test: tier1



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8383864: G1: Separate worker-local refinement data from shared concurrent refinement stats (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31040/head:pull/31040
$ git checkout pull/31040

Update a local copy of the PR:
$ git checkout pull/31040
$ git pull https://git.openjdk.org/jdk.git pull/31040/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31040

View PR using the GUI difftool:
$ git pr show -t 31040

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31040.diff

Using Webrev

Link to Webrev Comment

@albertnetymk albertnetymk changed the title g1-stats-atomic 8383864 May 5, 2026
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 5, 2026

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 5, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title 8383864 8383864: G1: Separate worker-local refinement data from shared concurrent refinement stats May 5, 2026
@openjdk openjdk Bot added the hotspot-gc hotspot-gc-dev@openjdk.org label May 5, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 5, 2026

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 5, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-gc. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 5, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 5, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant