8383850: Move TestLargeUTF8Length.java to resourcehogs

[jsikstro]

Hello,

This PR moves test/hotspot/jtreg/runtime/jni/checked/TestLargeUTF8Length.java and its native counterpart into the resourcehogs test folder.

TestLargeUTF8Length.java requires a large amount of memory and runs its sub-VM with -Xms9G -Xmx9G. The increased memory pressure on the machine from this test can negatively affect other tests running concurrently.

We've seen failures in other tests caused by TestLargeUTF8Length.java running simultaneously on a machine with Automatic Heap Sizing, but the move also makes sense right now in mainline because of the test's high memory requirement.

One impact of this change is that TestLargeUTF8Length.java is no longer included in the hotspot_runtime test group, but in hotspot_resourcehogs instead. This is fine as long as CI testing and other regular testing runs both groups periodically.

Testing:

• I've verified that the test is runnable in its new location, and that it is included in the hotspot_resourcehogs test group.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8383850: Move TestLargeUTF8Length.java to resourcehogs (Enhancement - P4)

Reviewers

• Axel Boldt-Christmas (@xmas92 - Reviewer)
• Johan Sjölen (@johan-sjolen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31038/head:pull/31038
$ git checkout pull/31038

Update a local copy of the PR:
$ git checkout pull/31038
$ git pull https://git.openjdk.org/jdk.git pull/31038/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31038

View PR using the GUI difftool:
$ git pr show -t 31038

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31038.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8383850: Move TestLargeUTF8Length.java to resourcehogs

Reviewed-by: aboldtch, jsjolen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 70f20f9: 8383770: Remove flags from AOTCodeCache::Config already covered by cpu features
• 91933ed: 8381862: Refactor remaining TestNG tests under jdk/net/ExtendedSocketOption to use JUnit
• 1be2fc4: 8383243: Make objcopy configurable to compress debug info
• ... and 2 more: https://git.openjdk.org/jdk/compare/65670ba43ba0e7f67b3dbabae1fc6c3542a5edf8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jsikstro The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-runtime. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 00: Full (6177c167)

[xmas92]

lgtm.

[johan-sjolen]

Seems reasonable, LGTM.

[Arraying]

The change is very reasonable, but why does the test @requires os.maxMemory > 15g? Do we eat memory somewhere in the native code? Could this be reduced?

[jsikstro]

The change is very reasonable, but why does the test @requires os.maxMemory > 15g? Do we eat memory somewhere in the native code? Could this be reduced?

That's actually a good point. @requires os.maxMemory > 15g was added in JDK-8370646 since the test couldn't be run concurrently on machines with lower memory than that.

Now that we're moving the test to resourcehogs/ we could lower this requirement a bit if we want since the test will run serially, but still leave some room for other "stuff" on the machine. Maybe 12 or 13 gigabyte is a good number? But leaving it at 15 doesn't seem like a big problem to me either.