8382035: [ubsan] Under UBSAN builds, disable tests that rely on simulated JVM crashes#31035
8382035: [ubsan] Under UBSAN builds, disable tests that rely on simulated JVM crashes#31035MBaesken wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@MBaesken The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
| * @bug 8193124 | ||
| * @summary Test the clhsdb 'findpc' command with Xcomp on live process | ||
| * @requires vm.hasSA | ||
| * @requires !vm.ubsan |
There was a problem hiding this comment.
Why are you disabling this @test? This is not a core file test. I expected to see this on xcomp-core and no-xcomp-core below.
| * @bug 8190198 | ||
| * @summary Test clhsdb pmap command on a live process | ||
| * @requires vm.hasSA | ||
| * @requires !vm.ubsan |
There was a problem hiding this comment.
Same comment here as above. This is not a core file test. The one below is.
| * @bug 8190198 | ||
| * @summary Test clhsdb pstack command on a live process | ||
| * @requires vm.hasSA | ||
| * @requires !vm.ubsan |
There was a problem hiding this comment.
Same comment here as above. This is not a core file test. The one below is.
There are a couple of tests that do not work well with ubsan - enabled binaries.
Thoe have been identified by Afshin
runtime/ErrorHandling/TestDwarf.java uses artificial division by zero
runtime/ErrorHandling/VeryEarlyAssertTest.java uses artificial env var to crash early in jvm load
serviceability/sa/ClhsdbFindPC.java
serviceability/sa/ClhsdbCDSCore.java
serviceability/sa/ClhsdbPstack.java
serviceability/sa/ClhsdbPmap.java
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31035/head:pull/31035$ git checkout pull/31035Update a local copy of the PR:
$ git checkout pull/31035$ git pull https://git.openjdk.org/jdk.git pull/31035/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31035View PR using the GUI difftool:
$ git pr show -t 31035Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31035.diff
Using Webrev
Link to Webrev Comment