Skip to content

8382035: [ubsan] Under UBSAN builds, disable tests that rely on simulated JVM crashes#31035

Open
MBaesken wants to merge 1 commit intoopenjdk:masterfrom
MBaesken:JDK-8382035
Open

8382035: [ubsan] Under UBSAN builds, disable tests that rely on simulated JVM crashes#31035
MBaesken wants to merge 1 commit intoopenjdk:masterfrom
MBaesken:JDK-8382035

Conversation

@MBaesken
Copy link
Copy Markdown
Member

@MBaesken MBaesken commented May 5, 2026

There are a couple of tests that do not work well with ubsan - enabled binaries.
Thoe have been identified by Afshin

runtime/ErrorHandling/TestDwarf.java uses artificial division by zero
runtime/ErrorHandling/VeryEarlyAssertTest.java uses artificial env var to crash early in jvm load
serviceability/sa/ClhsdbFindPC.java
serviceability/sa/ClhsdbCDSCore.java
serviceability/sa/ClhsdbPstack.java
serviceability/sa/ClhsdbPmap.java



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8382035: [ubsan] Under UBSAN builds, disable tests that rely on simulated JVM crashes (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31035/head:pull/31035
$ git checkout pull/31035

Update a local copy of the PR:
$ git checkout pull/31035
$ git pull https://git.openjdk.org/jdk.git pull/31035/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31035

View PR using the GUI difftool:
$ git pr show -t 31035

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31035.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 5, 2026

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 5, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title JDK-8382035: [ubsan] Under UBSAN builds, disable tests that rely on simulated JVM crashes 8382035: [ubsan] Under UBSAN builds, disable tests that rely on simulated JVM crashes May 5, 2026
@openjdk openjdk Bot added serviceability serviceability-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org labels May 5, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 5, 2026

@MBaesken The following labels will be automatically applied to this pull request:

  • hotspot-runtime
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 5, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-runtime. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 5, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 5, 2026

Webrevs

* @bug 8193124
* @summary Test the clhsdb 'findpc' command with Xcomp on live process
* @requires vm.hasSA
* @requires !vm.ubsan
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you disabling this @test? This is not a core file test. I expected to see this on xcomp-core and no-xcomp-core below.

* @bug 8190198
* @summary Test clhsdb pmap command on a live process
* @requires vm.hasSA
* @requires !vm.ubsan
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here as above. This is not a core file test. The one below is.

* @bug 8190198
* @summary Test clhsdb pstack command on a live process
* @requires vm.hasSA
* @requires !vm.ubsan
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here as above. This is not a core file test. The one below is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants