8383807: Parallel: Improve Young GC stack trimming#31024
8383807: Parallel: Improve Young GC stack trimming#31024albertnetymk wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Improve Parallel GC promotion stack trimming for the single-GC-worker case.
Previously,
PSPromotionManagerused a drain target of0whenParallelGCThreads == 1, so intermediate stack-processing points fully drained the promotion stack. Full draining is expensive and unnecessary there; the stack only needs bounded trimming, with explicit full drains kept at termination points.This change separates bounded trimming from full draining:
trim_stacks()trims toGCDrainStackTargetSizedrain_stacks()fully drains the stackRunning the attachment in JBS shows ~8% improvement for the
-XX:ParallelGCThreads=1case, and perf-neutral for multiple gc threads case.Test: tier1
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31024/head:pull/31024$ git checkout pull/31024Update a local copy of the PR:
$ git checkout pull/31024$ git pull https://git.openjdk.org/jdk.git pull/31024/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31024View PR using the GUI difftool:
$ git pr show -t 31024Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31024.diff
Using Webrev
Link to Webrev Comment