8373289: Test tools/javac/patterns/Exhaustiveness.java timed out then passed#31020
Open
lahodaj wants to merge 3 commits intoopenjdk:masterfrom
Open
8373289: Test tools/javac/patterns/Exhaustiveness.java timed out then passed#31020lahodaj wants to merge 3 commits intoopenjdk:masterfrom
lahodaj wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
sendaoYan
reviewed
May 4, 2026
| tb = new ToolBox(); | ||
| } | ||
|
|
||
| public void runTests() throws Exception { |
Member
There was a problem hiding this comment.
Do we need @Override for this method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test/langtools/tools/javac/patterns/Exhaustiveness.javacontains some degree of randomness (it will generate a big switch, and randomly remove a case from the switch, observing the outcomes). But, both generating the big switch, and the exhaustiveness computation process in javac as such are currently not deterministic, which leads to problems with reproducing any timeout/failure of the test.The intent in this PR is to ensure the exhaustiveness computation is deterministic, by using
LinkedHashSetandLinkedHashMap.With this change, if the test fails, there will be a better chance on reproducing the failure.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31020/head:pull/31020$ git checkout pull/31020Update a local copy of the PR:
$ git checkout pull/31020$ git pull https://git.openjdk.org/jdk.git pull/31020/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31020View PR using the GUI difftool:
$ git pr show -t 31020Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31020.diff
Using Webrev
Link to Webrev Comment