Skip to content

8382935: TestHeapSummaryEventG1.java does not support concurrent cycles#31018

Open
sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
sendaoYan:jbs8382935
Open

8382935: TestHeapSummaryEventG1.java does not support concurrent cycles#31018
sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
sendaoYan:jbs8382935

Conversation

@sendaoYan
Copy link
Copy Markdown
Member

@sendaoYan sendaoYan commented May 2, 2026

Hi all,

HeapSummaryEventAllGcs assumed that each After GC event immediately follows its matching Before GC in JFR event order. G1 can emit Before GC for a concurrent-mark gcId before several intervening pauses complete; the matching After GC for that gcId is emitted at concurrent cycle end, so event order is not strictly nested by arrival order.

Track pending gcIds from Before GC events per event type and match After GC events by removing the corresponding gcId, instead of comparing to the last seen event. Assert no unmatched Before events remain. Align the heap vs metaspace sanity check using the last Before gcId from each stream.

Additional testing:

  • All tests invoke test/jdk/jdk/jfr/event/gc/heapsummary/HeapSummaryEventAllGcs.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8382935: TestHeapSummaryEventG1.java does not support concurrent cycles (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31018/head:pull/31018
$ git checkout pull/31018

Update a local copy of the PR:
$ git checkout pull/31018
$ git pull https://git.openjdk.org/jdk.git pull/31018/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31018

View PR using the GUI difftool:
$ git pr show -t 31018

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31018.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 2, 2026

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 2, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the hotspot hotspot-dev@openjdk.org label May 2, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 2, 2026

@sendaoYan The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 2, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 2, 2026
@sendaoYan
Copy link
Copy Markdown
Member Author

Verified command:
jtreg -conc:5 test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventG1.java test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventPSParOld.java test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventDefNewSerial.java

@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 2, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant