8382935: TestHeapSummaryEventG1.java does not support concurrent cycles#31018
8382935: TestHeapSummaryEventG1.java does not support concurrent cycles#31018sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@sendaoYan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
|
Verified command: |
Hi all,
HeapSummaryEventAllGcs assumed that each After GC event immediately follows its matching Before GC in JFR event order. G1 can emit Before GC for a concurrent-mark gcId before several intervening pauses complete; the matching After GC for that gcId is emitted at concurrent cycle end, so event order is not strictly nested by arrival order.
Track pending gcIds from Before GC events per event type and match After GC events by removing the corresponding gcId, instead of comparing to the last seen event. Assert no unmatched Before events remain. Align the heap vs metaspace sanity check using the last Before gcId from each stream.
Additional testing:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31018/head:pull/31018$ git checkout pull/31018Update a local copy of the PR:
$ git checkout pull/31018$ git pull https://git.openjdk.org/jdk.git pull/31018/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31018View PR using the GUI difftool:
$ git pr show -t 31018Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31018.diff
Using Webrev
Link to Webrev Comment