Merged
Conversation
Collaborator
|
Thanks Michael - could you apply the change to the 1.0 examples folder too please as we'd want to include this in the errata |
Contributor
Author
|
Yep - updated @jogu |
Vanderkast
approved these changes
Feb 25, 2026
fkj
approved these changes
Feb 25, 2026
Member
fkj
left a comment
fkj
left a comment
There was a problem hiding this comment.
Looks good to me. We should add a change note for the errata of 1.0 about this.
c2bo
approved these changes
Feb 26, 2026
Member
c2bo
left a comment
c2bo
left a comment
There was a problem hiding this comment.
Adding a note to document history would be good. looks good otherwise
jogu
approved these changes
Feb 26, 2026
jogu
added a commit
to openid-certification/conformance-suite
that referenced
this pull request
Apr 14, 2026
…jected The OID4VCI 1.0 Final Appendix I example shows `credential_request_encryption.jwks` as a bare JWK array, which contradicts the normative text in section 12.2.4 defining it as a JWK Set (an object with a `keys` array). Spec errata openid/OpenID4VCI#711 corrects the example. Lock in the conformance suite's interpretation with a negative fixture so any future relaxation of the schema is caught. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raised to address #683