Fixing delete files flag and other improvements#97
Conversation
suricactus
left a comment
There was a problem hiding this comment.
Probably I miss something, but what is the difference if you pass --paths and --filter?
Aren't they doing exactly the same, especially if you combine them together all_patterns = list(paths) + list(filter) ?
Actually the --paths is not an option, and this is for given the list of files, example:
When trying to use the --paths return the following error: qfieldcloud-cli delete-files "b4dc48e4-5fd1-4b82-8b16-a4403bfee804" --paths "DCIM/tree-202411202334943.jpg' 'DCIM/tree-202411202331234.jpg"
Usage: qfieldcloud-cli delete-files [OPTIONS] PROJECT_ID [PATHS]...
Try 'qfieldcloud-cli delete-files --help' for help.
Error: No such option: --paths |
|
Ok, sorry, you are right about the usage. But still, what is the functional difference between the two? |
Is more for give the user the explicit |
|
We keep either or, but not both. I see two paths forward:
Personally I woul like prefer if there is no change. |
|
At the moment I would like to prefer to close it, and when needed create a new PR! 🦾 🥷 |
In this PR added the option to use the
qfieldcloud-cli delete-fileswith a path, paths or by using directly the--filteroption and other improvement in the count of the success and failed deleted files.