Skip to content

Move game history action buttons onto map previews - #4837

Open
Aotumuri wants to merge 2 commits into
openfrontio:mainfrom
Aotumuri:fix-icon-2
Open

Move game history action buttons onto map previews#4837
Aotumuri wants to merge 2 commits into
openfrontio:mainfrom
Aotumuri:fix-icon-2

Conversation

@Aotumuri

@Aotumuri Aotumuri commented Aug 3, 2026

Copy link
Copy Markdown
Member

Description:

This is a follow-up to #4824 based on this post-merge review comment:

#4824 (comment)

This is a separate follow-up PR because the feedback was posted after #4824 had already been merged. Sorry for the additional PR.


Moves the Stats and Replay action buttons onto the top-left corner of the map preview in both player and clan game history cards.
This removes the mostly empty action row and reduces dead space.

before
スクリーンショット 2026-08-03 16 57 59

after
スクリーンショット 2026-08-03 17 18 22

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

aotumuri

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: be7eb7b6-e34b-4a22-a7b2-2a7ee48afc94

📥 Commits

Reviewing files that changed from the base of the PR and between 54d6721 and 3da03d9.

📒 Files selected for processing (2)
  • src/client/components/baseComponents/stats/PlayerGameHistoryView.ts
  • src/client/components/clan/ClanGameHistoryView.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/client/components/clan/ClanGameHistoryView.ts

Walkthrough

Game history cards now use wider map images, top-left result badges, and conditional action overlays. Cards without map images retain inline headers. Stats buttons now use the same blue styling as replay buttons.

Changes

Game history overlays

Layer / File(s) Summary
Map card layout and conditional controls
src/client/components/baseComponents/stats/PlayerGameHistoryView.ts, src/client/components/clan/ClanGameHistoryView.ts
Cards use relative positioning and wider map image ratios. Result badges move to the top-left. Action controls overlay map-backed cards and remain inline for cards without maps. Stats buttons use blue action-button styling.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: UI/UX

Suggested reviewers: evanpelle, celant, ryanbarlow97

Poem

Maps grow wide across the card,
Badges move left and actions guard.
Blue stats buttons join replay,
Headers stay when maps are away.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes moving game history action buttons onto map previews, which is the main change.
Description check ✅ Passed The description explains the UI changes, affected views, motivation, screenshots, tests, and translation requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants