fix player emoji hiding player status

[JB940]

Before opening a PR: discuss new features on Discord first, and file bugs or small improvements as issues. You must be assigned to an approved issue — unsolicited PRs will be auto-closed.

Add approved & assigned issue number here:

Resolves #4829

Description:

This PR solves player global emoting hiding all their status icons. A player could permanently hide them by emoting in intervals. This PR shows the emoji next to the status icons, properly re-centering the entire set of icons above a players' name.

• Single source of truth: the status icons now live in index.ts. Adding a new status icon only requires updating one place since the emoji draw also depends on it.
• Both shaders simplified: status-icon.vert.glsl loses the counting loop (saving 3 lines); icon.vert.glsl loses the pd5/pd6 fetches and the dot(step()) expression (saving 4 lines + 2 texture reads).
• pd8 was already fetched at the top of status-icon.vert.glsl's main(), so int(pd8.z) there is completely free.

Please complete the following:

• I have added screenshots for all UI updates

Please put your Discord username so you can be contacted if a bug or regression is found:

JB940

[coderabbitai]

Walkthrough

The name pass now stores the active status-icon count in player-data column 8. The count includes relation, state, target, embargo, nuke, and doomsday icons.

Changes

Status icon encoding

Layer / File(s)	Summary
Encode active status icons src/client/render/gl/passes/name-pass/index.ts	writePlayerDataRow now computes the active status-icon count and stores it in player-data column 8 with the crown layer and verified badge.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openfrontio/OpenFrontIO#4518: Both update writePlayerDataRow to encode Doomsday Clock status in column 8.
• openfrontio/OpenFrontIO#4816: Both update status-icon handling for player name rendering.
• openfrontio/OpenFrontIO#4353: Both update name-pass player-data handling for status icons.

Suggested labels: UI/UX

Suggested reviewers: evanpelle

Poem

Icons gather, counted bright,
Column eight now holds their light.
Crowns and badges take their place,
Status stays within the trace.
Names reveal what sprites convey.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	❓ Inconclusive	The core emoji visibility and re-centering logic is in two excluded GLSL files, so compliance with issue #4829 cannot be verified.	Include the excluded GLSL files in review, or provide evidence that they preserve status icons and re-center emojis as required by issue #4829.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Out of Scope Changes check	✅ Passed	The reviewed change supports the stated status-icon counting and emoji/status display objectives, with no unrelated changes shown.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title clearly identifies the fix for player emotes hiding status icons.
Description check	✅ Passed	The description directly explains the status-icon visibility fix and related shader and rendering changes.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[JB940]

With that fix it now scales properly and looks really normal