fix(lang): change missile intercepted notification to SAM intercepted - #4825
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe English interception event translation now identifies the intercepting unit as a SAM. The ChangesInterception message
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add approved & assigned issue number here:
Resolves n/a
Description:
When a SAM launcher shoots down an incoming nuke, the event log currently says
"Missile intercepted [Unit]"(e.g., "Missile intercepted Atom Bomb"). Since both the interceptor and the nuke are missiles, the phrasing feels a bit awkward.I updated the
"missile_intercepted"string to"SAM intercepted {unit}"(e.g., "SAM intercepted Atom Bomb"). This makes it immediately clear that your SAM did the intercepting and matches the rest of the in-game SAM terminology ("SAM Launcher", "SAMs Disabled").Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
blontd6