Skip to content

fix(lang): change missile intercepted notification to SAM intercepted - #4825

Merged
evanpelle merged 1 commit into
openfrontio:mainfrom
blontd6:patch/sam-intercept-lang
Aug 2, 2026
Merged

fix(lang): change missile intercepted notification to SAM intercepted#4825
evanpelle merged 1 commit into
openfrontio:mainfrom
blontd6:patch/sam-intercept-lang

Conversation

@blontd6

@blontd6 blontd6 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Add approved & assigned issue number here:

Resolves n/a

Description:

When a SAM launcher shoots down an incoming nuke, the event log currently says "Missile intercepted [Unit]" (e.g., "Missile intercepted Atom Bomb"). Since both the interceptor and the nuke are missiles, the phrasing feels a bit awkward.

I updated the "missile_intercepted" string to "SAM intercepted {unit}" (e.g., "SAM intercepted Atom Bomb"). This makes it immediately clear that your SAM did the intercepting and matches the rest of the in-game SAM terminology ("SAM Launcher", "SAMs Disabled").

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

blontd6

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e194917e-ceb2-40d6-91b2-688a1ef059cf

📥 Commits

Reviewing files that changed from the base of the PR and between 753c66e and 804137b.

📒 Files selected for processing (1)
  • resources/lang/en.json

Walkthrough

The English interception event translation now identifies the intercepting unit as a SAM. The {unit} placeholder remains unchanged.

Changes

Interception message

Layer / File(s) Summary
Update interception translation
resources/lang/en.json
The message changes from “Missile intercepted” to “SAM intercepted” and retains the {unit} placeholder.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: evanpelle

Poem

A missile meets its match,
A SAM completes the task.
The message now speaks true,
With {unit} still in view.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the translation change from missile interception to SAM interception.
Description check ✅ Passed The description directly explains the notification change and its purpose in the game.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the small-fix Small fix (≤ 50 lines) — auto-applied by PR gate label Aug 2, 2026
@evanpelle evanpelle added this to the v33 milestone Aug 2, 2026
@evanpelle
evanpelle merged commit 5d01149 into openfrontio:main Aug 2, 2026
12 of 13 checks passed
@github-project-automation github-project-automation Bot moved this from Triage to Complete in OpenFront Release Management Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small-fix Small fix (≤ 50 lines) — auto-applied by PR gate

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants