Skip to content

Gumgum - #4691

Draft
evanpelle wants to merge 5 commits into
mainfrom
gumgum
Draft

Gumgum#4691
evanpelle wants to merge 5 commits into
mainfrom
gumgum

Conversation

@evanpelle

Copy link
Copy Markdown
Collaborator

Before opening a PR: discuss new features on Discord first, and file bugs or small improvements as issues. You must be assigned to an approved issue — unsolicited PRs will be auto-closed.

Add approved & assigned issue number here:

Resolves #(issue number)

Description:

Describe the PR.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

DISCORD_USERNAME

Celant and others added 2 commits July 23, 2026 10:35
…t cover nav bar

Playwire's "flex" ad unit injects #pw-oop-flex_container as body's first
child. Since body uses flex/flex-row/overflow-hidden for its own layout,
the ad's wrapper (unlike its already-fixed inner content) becomes an
untracked flex item that distorts the layout and lets the ad's
fixed/max-z-index creative cover the nav bar with no reserved space.

Mirrors the existing bottom_rail handling by taking the container out of
flex flow, and adds a --flex-ad-height custom property (kept in sync via
ResizeObserver/MutationObserver) so body's padding-top pushes content
below the ad instead of under it.
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 94367359-a656-4b26-869c-951bdb2f8173

📥 Commits

Reviewing files that changed from the base of the PR and between e2d73f8 and 8a8f762.

📒 Files selected for processing (1)
  • Dockerfile

Walkthrough

index.html reserves and tracks space for Playwire’s top flex ad, fixes the ad wrapper, and loads a new Gum Gum header-ad script. Dockerfile also extends the conditional supervisord timeout from 25 to 150 hours.

Changes

Ad layout and integration

Layer / File(s) Summary
Flex ad layout and height tracking
index.html
Body padding includes safe-area and dynamic ad height. The Playwire container is fixed at the top, while observers update the height variable.
Header ad script update
index.html
The footer Gum Gum header-ad script uses a new Intergient ramp asset.

Runtime duration

Layer / File(s) Summary
Supervisord timeout update
Dockerfile
The affected startup branch increases the supervisord timeout from 25 hours to 150 hours.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant AdContainer
  participant ResizeObserver
  participant MutationObserver
  participant BodyStyle
  AdContainer->>ResizeObserver: report rendered height
  ResizeObserver->>BodyStyle: set --flex-ad-height
  MutationObserver->>BodyStyle: reset or resync after DOM changes
  BodyStyle->>BodyStyle: update body padding-top
Loading

Suggested reviewers: celant

Poem

A flex ad floats up high,
Its measured height joins the sky.
Padding shifts, the layout stays,
A longer timer lights the way.
New ramp signals guide the day.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too vague to describe the actual changes, so it does not help a teammate understand the PR. Use a short, specific title that mentions the main change, such as the Gumgum ad layout and timeout update.
Description check ❓ Inconclusive The description is mostly a template and does not explain the implemented changes, but it is not off-topic. Replace the template text with a brief summary of the actual changes and why they were made.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@index.html`:
- Around line 538-543: Update the RAMP script URL in the Gum Gum header ads
block to the protocol-relative form used by the adjacent script, preserving the
existing host and path so InGamePromo.ts can load window.ramp.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22258cb1-9499-4983-9ca6-b70e34696d60

📥 Commits

Reviewing files that changed from the base of the PR and between cade1cc and fd2266b.

📒 Files selected for processing (1)
  • index.html

Comment thread index.html
@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management Jul 23, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 23, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development

Development

Successfully merging this pull request may close these issues.

2 participants