-
Notifications
You must be signed in to change notification settings - Fork 765
skip token signature in dev mode #2793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds logic to skip token signature verification in development mode to avoid authentication issues during local development. The changes allow developers to bypass JWT validation and user permission checks when GAME_ENV is set to "dev".
Key changes:
- Skip
verifyClientToken()in dev mode, usingclientIDaspersistentIdinstead - Skip
getUserMe()call in dev mode, leaving roles and flares undefined - Add conditional logic to handle both production (authenticated) and dev (unauthenticated) flows
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
VectorSophie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of fixing this whenever i would locally test my PRs, this is a really good QoL change.
Description:
Skip token signature when in dev, I keep getting issues 😢
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
w.o.n