Upgrade to shakapaker #13828
Open
Upgrade to shakapaker #13828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are still using the old `ruby-sass` because it's a dependency from `rails-sass` which is a dependcy from `select2`. It looks like the master branch on the ofn fork get rid of the dependency, so we should upgrading.
Move the Postcss config hack to postcss.config.js
Trying to stay as close as possible to the default config
We are not planning to upgrade foundation-sites
Stimulus doesn't support IE 11 : https://stimulus.hotwired.dev/handbook/installing#browser-support
Disable overlayi, it covers the whole page as we have lots of warning
It's need for jest to work properly.
rioug
force-pushed
the
10298-upgrade-to-shakapaker
branch
from
35ee2fb to
6ca5e2e
Compare
rioug
added
the
technical changes only
rioug
force-pushed
the
10298-upgrade-to-shakapaker
branch
from
075cbce to
e4886c7
Compare
It seems that we have functionality that depends on the order the scripts are executed. Using defer breaks that. Using defer is better performance wise so we should try to address this eventually, might need to wait till we get rid of angular.
On CI assets are precompiled so it should not be needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Move to
shakapackerwhich lets us use the latest version ofwepackWhat should we test?
Green specs 🟢
I wouldn't hurt to do a standard release test as well to make sure everything is working as expected.
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.