-
-
Notifications
You must be signed in to change notification settings - Fork 761
Fix “Import multiple products” button route on empty products page #13821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix “Import multiple products” button route on empty products page #13821
Conversation
|
Gracias — esto arregla el enlace roto y se ve bien. Probé el flujo localmente: en Admin → Products con la lista vacía, el botón "Import multiple products" ahora abre correctamente la página de importación, y también funciona cuando ya hay productos.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me. 🎉
Now we will wait for the 2nd review before moving to the manual testing, @piyyu. Thanks
|
@spreadFact thanks for the suggestion! Happy to add a system spec in a follow-up if needed 👍 |
mkllnk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Great work.
| expect(page).to have_link(class: "button", text: "New Product", href: "/admin/products/new") | ||
| expect(page).to have_link(class: "button", text: "Import multiple products", | ||
| href: "/admin/products/import") | ||
| href: admin_product_import_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it would be okay to use the explicit string. Otherwise we are not testing much here and just mirroring the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, do as you wish,if you need some thing more ,
|
Yes, do as you handle it better is not for me an problem,
Wish you be well
…On Fri, 2 Jan 2026, 06:53 Maikel, ***@***.***> wrote:
***@***.**** approved this pull request.
Thank you! Great work.
------------------------------
In spec/system/admin/products_v3/actions_spec.rb
<#13821 (comment)>
:
> - href: "/admin/products/import")
+ href: admin_product_import_path)
Here it would be okay to use the explicit string. Otherwise we are not
testing much here and just mirroring the code.
—
Reply to this email directly, view it on GitHub
<#13821 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B37GPQWI7B3A6JCC2N7BOM34EYBVLAVCNFSM6AAAAACQAPWZRWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMRSGI2DKNBQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
What? Why?
The "Import multiple products" button was linking to a non-existent route
(
/admin/products/import), which resulted in a "Not Found" error when clicked,especially visible when there were no products.
This change updates the button to use the correct
admin_product_import_path, ensuring it correctly navigates to the productimport page.
What should we test?
Release notes
Changelog Category:
Dependencies
None
Documentation updates
None