Skip to content

Conversation

@ashishp91
Copy link
Contributor

…f it's too long

What? Why?

  • Closes #

What should we test?

  • Visit ... page.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@ashishp91
Copy link
Contributor Author

@dacook @mkllnk I added a guard condition on the adjustment label generation method to use only the product name if it's too long. Does this feel like an acceptable solution ?

Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashishp91 , that would avoid an error which is great, but it means that the product name would disappear without explanation, which would be confusing.
I think it would be better to use truncation in this case. Rails provides an easy method for this: https://apidock.com/rails/v7.1.3.2/String/truncate
You could pass in the column limit to this method.

@github-project-automation github-project-automation bot moved this from All the things 💤 to In Progress ⚙ in OFN Delivery board Jul 21, 2025
@dacook
Copy link
Member

dacook commented Jul 21, 2025

Also can you please fill out the first two parts of the PR description? You just need to add the issue number and some details how to test (you can just point to the issue "steps to reproduce" section).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress ⚙

Development

Successfully merging this pull request may close these issues.

2 participants